feature: adding assets.Manager#Path - #42
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Path method to the assets Manager as a convenience wrapper around PathFor. The method returns the fingerprinted asset path on success, or falls back to the original name on error, making it easier to use in templates where error handling is cumbersome.
- Added
Manager.Path()method that wrapsPathFor()and returns the original name on errors - Updated concurrent test loop to use modern Go range syntax (
for i := range goroutines) - Added comprehensive test coverage for the new
Pathmethod with success and error cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| assets/fingerprint.go | Implements the new Path method with error-swallowing behavior and adds clarifying comment to PathFor |
| assets/fingerprint_test.go | Adds test coverage for the new Path method and modernizes loop syntax in concurrent test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the assets.Manager#Path method as a higher level accessor to assets path. If an error is found by it this returns the passed name.