Repository navigation
fix(safety): secure helper and recover interrupted hardware control - #24
Merged
Merged
Conversation
Install a protected helper copy and supervise foreground discharge in the root daemon. Restore failed fan operations, retry incomplete recovery, and reject non-finite safety inputs.
Reject extended ACLs on the fixed installation path and clear copied ACLs inside a private staging directory. Let connection invalidation end only its own discharge session and correct the restart help text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The root daemon could execute a user-replaceable helper, and interrupted hardware writes or foreground discharge could leave manual control active. Non-finite temperature inputs could also bypass the thermal guard.
What changed
Scope
Fix the four high-priority findings. Other audit findings and hardware-specific DDC changes are excluded. Old daemons must be reinstalled before the new CLI will start supervised discharge.
Blast Radius
Touches daemon installation, all manual fan write callers, thermal safety, and adapter control. Manual adapter toggles remain separate from supervised discharge. Homebrew upgrades now require
sudo smctl daemon installto update the protected copy.Verification