fix: namespace used in private import and current module vanishes dowstream#12840
Draft
Kha wants to merge 2 commits intoleanprover:masterfrom
Draft
fix: namespace used in private import and current module vanishes dowstream#12840Kha wants to merge 2 commits intoleanprover:masterfrom
Kha wants to merge 2 commits intoleanprover:masterfrom
Conversation
Kha
commented
Mar 8, 2026
| /-- Return a set containing all namespaces in `env`. -/ | ||
| def getNamespaceSet (env : Environment) : NameSSet := | ||
| /-- Returns a set (more specifically, a map to namespace visibility) containing all namespaces in `env`. -/ | ||
| public def getNamespaceSet (env : Environment) : SMap Name Visibility := |
Member
Author
There was a problem hiding this comment.
@datokrat This is the def I would like to move to an iterator, for which we would need to append the two SMap parts
Member
Author
|
!bench |
|
Benchmark results for c00b30c against 333ab1c are in! @Kha
Small changes (1✅, 1🟥)
|
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 9, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 9, 2026
mathlib-lean-pr-testing
bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the use of private imports led to unknown namespaces in downstream modules.
Fixes #12833