feat: add lock file maintenance to automerge preset#83
Conversation
JonaLoefflerLeanix
requested review from
StefanKuerten1234,
kostas-petrakis,
liudmyla-b,
r0binary-sap and
timovankissing-leanix
|
📊 Survey: Please help us track internal AI adoption. This is not for evaluation, only for metrics. You can update this anytime before merge.
🧑💻 If AI was used, what was it mainly used for?
Thank you in advance for your feedback.💙🙏🎉 |
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR correctly adds lockFileMaintenance automerge support and updates the README, but the schedule expression * 9-13 * * 1-5 (copied from the existing block) has an overly broad minutes field — using a human-readable Renovate schedule string or fixing the minutes position to 0 would make the intent unambiguous.
PR Bot Information
Version: 1.20.23
- LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened - Correlation ID:
a363e753-d313-4826-b2fd-082505cf867d - File Content Strategy: Full file content
|
Hey Jona, nice contribution. A few remarks to consider:
|
Yes, this was meant more as a suggestion and to get the ball rolling. Happy to hand it over to you 🙏 |
SummaryThe following content is AI-generated and provides a summary of the pull request: Add Lock File Maintenance to Automerge PresetNew Feature✨ Extends the shared Lock file maintenance PRs are low-risk updates (they only refresh the lock file without altering version ranges) but were previously not covered by the Changes
PR Bot InformationVersion:
|
There was a problem hiding this comment.
The PR introduces a critical bug: "lockFileMaintenance" is not a valid matchUpdateTypes value, so placing it inside the packageRule will have no effect and lock file maintenance PRs will never actually be automerged. The fix requires adding a dedicated top-level lockFileMaintenance config block, as detailed in the review comment above.
PR Bot Information
Version: 1.20.33
- File Content Strategy: Full file content
- Correlation ID:
17d81d3d-32e7-43fa-af72-05f1d87e1c2e - Event Trigger:
pull_request.ready_for_review - LLM:
anthropic--claude-4.6-sonnet
Move lock file maintenance automerge config from a separate lockFileMaintenance block into the existing packageRules entry by adding lockFileMaintenance to matchUpdateTypes.
r0binary-sap
force-pushed
the
feature/automerge-lock-file-maintenance
branch
from
3a4ed68 to
9131b54
Compare
|
@JonaLoefflerLeanix we'll do the announcement of this change, right? (Of course mentioning this was your contribution) |
Sounds good 👍 |
2 participants
Summary
lockFileMaintenanceautomerge configuration to the sharedautomerge.json5presetMotivation
Lock file maintenance PRs are low-risk (they only update the lock file without changing version ranges) but were not covered by the
matchUpdateTypespackage rule sincelockFileMaintenanceis a separate Renovate config key, not a standard update type.Test plan