fix(test): avoid duplicate slot in test_head_switches_to_heavier_fork#474
Open
latifkasuli wants to merge 1 commit intoleanEthereum:mainfrom
Open
fix(test): avoid duplicate slot in test_head_switches_to_heavier_fork#474latifkasuli wants to merge 1 commit intoleanEthereum:mainfrom
latifkasuli wants to merge 1 commit intoleanEthereum:mainfrom
Conversation
Move fork_b from slot 2 to slot 3, and its child from slot 3 to slot 4, so each block occupies a unique slot. The test still validates the core LMD-GHOST property: extending a fork with a child block (plus attestation) makes it heavier and switches the head. Addresses leanEthereum#470
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes another test case identified in #470 (
Avoid multiple-blocks-same-slot in all test cases).test_head_switches_to_heavier_forkcreated fork_a and fork_b at the same slot (2), violating the one-block-per-slot constraint.Test plan
uv run fill tests/consensus/devnet/fc/test_fork_choice_head.py --fork=Devnet -v-- all 6 tests passAddresses #470