fix(test): avoid duplicate slot in test_head_with_two_competing_forks#471
Merged
tcoratger merged 1 commit intoleanEthereum:mainfrom Mar 24, 2026
Merged
Conversation
Move fork_b from slot 2 to slot 3 so each block occupies a unique slot, respecting the one-block-per-slot protocol constraint. Both forks still have equal weight (1 proposer attestation each) and the head is validated via the lexicographic_head_among check. Addresses leanEthereum#470
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes one of the test cases identified in #470 (
Avoid multiple-blocks-same-slot in all test cases).test_head_with_two_competing_forkspreviously created two blocks at slot 2 (fork_a and fork_b), violating the one-block-per-slot protocol constraint.common).head_root_labelcheck withlexicographic_head_among=["fork_a", "fork_b"]since the forks are now at different slots and the winner depends on root ordering.Test plan
uv run fill tests/consensus/devnet/fc/test_fork_choice_head.py::test_head_with_two_competing_forks --fork=Devnet -vpassestest_fork_choice_head.pypass (no regressions)Addresses #470