tests: align test vectors with proposal/attestation key split behavior#461
Merged
tcoratger merged 5 commits intoleanEthereum:mainfrom Mar 20, 2026
Merged
Conversation
anshalshukla
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
After #449, the tests no longer gets a free proposer attestation included in each block. While the reftests were passing, they were passing because we introduced
gossip_proposer_attestationandinclude_store_attestationsthat are opaque to the clients.There were also some test cases where we assumed that a block always has an attestation, and so an additional fork depth guarantees an additional fork weight. But it's misleading to rely on fork depth because the fork choice rule doesn't consider depth at all.
This PR brings back the visibility by:
gossip_proposer_attestationandinclude_store_attestations, so that when clients parse aBlockStep, it only needs to process it throughstore.on_block()and no other ops.Also removed
test_auto_collect_*test because those are testing behaviors only specific to havingproposer_attestationSome review notes: If you see non-obvious changes in this PR, they're from (3) above because fork depths are replaced with attestations. The rest are just turning the implicit proposer attestations into explicit block.attestations.
🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox