Conversation
- Add 'Delete All Feeds in Folder' button in FeedsSetting with confirmation dialog - Fix navigation to show empty folders (persist folders even without feeds) - Localize DeleteConfirmDialog cancel/delete buttons via i18n - Add i18n keys for batch delete success/partial/failure messages - Fix fillFolderConnectors to include persisted folders with no connectors
🤖 Augment PR SummarySummary: Adds a “Delete All Feeds in Folder” action to the feeds settings UI and improves folder rendering when folders are empty. Changes:
Technical Notes: Batch deletion uses 🤖 Was this summary useful? React with 👍 or 👎 |
| }); | ||
| } | ||
| } finally { | ||
| await Promise.all([refetchConnectors(), refetchFolders()]); |
There was a problem hiding this comment.
await Promise.all([refetchConnectors(), refetchFolders()]) can throw if either refetch fails, which would skip setDeletingFolderFeeds(false) and potentially leave the UI stuck in a deleting/disabled state. Consider handling refetch failures so the deleting flag is always cleared.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fillFolderConnectorsto include persisted folders even when they have no connector items, and update the frontend navigation to correctly render empty foldersDeleteConfirmDialogcancel/delete button labels via i18n, and add new i18n keys for batch delete success, partial success, and failure messages in bothenandzh-CNlocalesChanges
FeedsSetting.tsx: batch-delete logic usingPromise.allSettled, snackbar feedback for all outcomesPrimaryNavigation.tsx: refactored folder-connector loop to show folders regardless of whether they have feedsConnectorService.java:fillFolderConnectorsnow includes persisted folders with empty connector listsDeleteConfirmDialog.tsx: usest('common:cancel')/t('common:delete')instead of hardcoded stringssettings.json(en/zh-CN): addeddeleteFolderFeeds,deleteFolderFeedsConfirmDesc,folderFeedsDeleted,folderFeedsPartiallyDeleted,folderFeedsDeleteFailedkeys