Conversation
🤖 Augment PR SummarySummary: This PR improves server-side feed fetching behavior and runtime configuration. Changes:
Technical Notes: Feed client caching is now process-wide (static), so behavior depends on the proxy/timeout key and shared cache directory. 🤖 Was this summary useful? React with 👍 or 👎 |
| .cache(FEED_CACHE) | ||
| .connectionSpecs(Arrays.asList(ConnectionSpec.MODERN_TLS, ConnectionSpec.COMPATIBLE_TLS, ConnectionSpec.CLEARTEXT)) | ||
| .followRedirects(true); | ||
| if (proxySetting != null && StringUtils.isNotBlank(proxySetting.getHost())) { |
There was a problem hiding this comment.
The proxy guard only checks host, but proxySetting.getPort() is unboxed when constructing InetSocketAddress and will NPE if the port is null. Consider also guarding port here to avoid crashing feed fetch when proxy config is partially populated.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| var size = PageSizeUtils.getPageSize(searchQuery.getSize(), 100); | ||
| var maxPage = 10000; | ||
| int startIndex = (page - 1) * size; | ||
| TopScoreDocCollector collector = TopScoreDocCollector.create(page * size, maxPage); |
There was a problem hiding this comment.
If a request passes page <= 0, then startIndex = (page - 1) * size and TopScoreDocCollector.create(page * size, ...) can go negative/zero and Lucene may throw at query time. Consider clamping page to at least 1 before using it in these calculations.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Summary
This PR includes several improvements across the server and browser extension:
Server Improvements
Browser Extension Improvements
Other Changes