Skip to content

exclude weird tagname from version-name#142

Merged
YAY-C merged 2 commits intomasterfrom
exclude_tagnames
Mar 2, 2026
Merged

exclude weird tagname from version-name#142
YAY-C merged 2 commits intomasterfrom
exclude_tagnames

Conversation

@YAY-C
Copy link
Contributor

@YAY-C YAY-C commented Mar 2, 2026

this is because Yuri needed an explicit tag name for the TMC-benchmark, but setuptools would complain because it gets attached to the version name, which breaks the installation of the package ...

non-compliant with `setuptools` version-names
@YAY-C YAY-C self-assigned this Mar 2, 2026
@YAY-C YAY-C requested a review from briling March 2, 2026 09:31
@YAY-C YAY-C added the bug Something isn't working label Mar 2, 2026
@YAY-C YAY-C mentioned this pull request Mar 2, 2026
2 tasks
@briling
Copy link
Contributor

briling commented Mar 2, 2026

i think this might be better:

git describe --tags --match 'v*' --dirty --always

Copy link
Contributor

@briling briling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have to hard code every new paper tag

@briling
Copy link
Contributor

briling commented Mar 2, 2026

or even

git describe --tags --match 'v[0-9]*' --dirty --always

@YAY-C YAY-C requested a review from briling March 2, 2026 16:47
@YAY-C YAY-C merged commit 360be55 into master Mar 2, 2026
8 checks passed
@YAY-C YAY-C deleted the exclude_tagnames branch March 2, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants