Conversation
|
I still need to update the tests, I was hoping for some help in generating the appropriate response in line with whatever your Solr test setup is. |
|
Hello @shiftyp, Firstly, I am really sorry I completely forgot/missed your pull request. Secondly, I would be really happy to merge your code and publish it in the next release. I will do this really soon like by the end of the week. Anyway if later I will publish your changes in another release. I just need you to add a couple things in order to merge it:
For the tests, I use the configuration that you can find here https://github.com/lbdremy/solr-node-client/tree/v0.3.x/test/materials when I test against Solr, on the latest version 3. By the way, I really appreciate that you committed your changes with the same formatting like I do, thanks 👍 ! |
|
ref #56 |
|
Hi @shiftyp, What's up? |
|
Hey, sorry I've been out of communication. I'll take care of this as soon as I get a chance, which will be soon. |
|
No worries, looking forward. |
|
@shiftyp, still there? If I don't hear from you, I'll look into merging this and writing the tests/ examples myself. |
|
This looks like a nice feature indeed. @luketaverne I think we should go ahead and merge. I can help here if you need. |
|
@nicolasembleton please go ahead and merge. |
|
Is this going to be merged? |
|
Wow, very old unfinished contribution flashback 😵. I may actually have some time coming up in January where I could work on this. Anyone else interested in this issue though can feel free to pick up in the meantime and address the conflicts and the three tasks outstanding:
|
|
@shiftyp Any chance you could finish this? |
I've updated the Query.prototype.facet method to allow for a "range" option to specify a facet range query.