refactor: createAddStream#303
Draft
ronag wants to merge 1 commit intolbdremy:masterfrom
Draft
Conversation
ronag
force-pushed
the
compose-pipeline
branch
from
5474667 to
d24e7d6
Compare
ronag
force-pushed
the
compose-pipeline
branch
from
d24e7d6 to
8647ebd
Compare
ronag
force-pushed
the
compose-pipeline
branch
from
8647ebd to
5311233
Compare
ronag
commented
Nov 10, 2021
Comment on lines
+303
to
+309
| return stream.compose( | ||
| JSONStream.stringify(), | ||
| undici.pipeline(optionsRequest.url, optionsRequest, ({ statusCode, headers, body }) => { | ||
| // TODO: | ||
| return body | ||
| }) | ||
| ) |
Author
There was a problem hiding this comment.
Node 14+
const jsonStreamStringify = JSONStream.stringify();
const req = undici.pipeline(optionsRequest.url, optionsRequest, ({ statusCode, headers, body }) => {
// TODO: statusCode & headers
return body;
});
return duplexer(jsonStreamStringify, pipeline(jsonStreamStringify, req, () => {}));
Collaborator
|
Thank you! I'll try to finish this in coming days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a quick suggestion on how to improve the implementation for Node 16+.