Provide raw solr response when JSON.parse fails#207
Open
nfriedly wants to merge 1 commit intolbdremy:masterfrom
Open
Provide raw solr response when JSON.parse fails#207nfriedly wants to merge 1 commit intolbdremy:masterfrom
nfriedly wants to merge 1 commit intolbdremy:masterfrom
Conversation
While rare, network issues, proxies, and other problems can result in invalid or incomplete JSON. The error message in that case is may not be particularly helpful, so this provides the raw response in a new error.body field to aid in debugging.
|
Can we get this merge? |
|
hello? |
1 similar comment
|
hello? |
Contributor
Author
|
@germanattanasio take a look at #133 - is there anybody at IBM who would be interested in taking over maintenance of this repo? |
|
Re deprecated the only service that was using Solr but I wanted to get your PR merge ha. |
|
Merry Christmas @nfriedly! |
Contributor
Author
|
Merry Christmas @germanattanasio! 🎄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer reported that when uploading hundreds of thousands of documents, a few could hit an "unexpected in of json" error here. This change adds the actual response text to the error object at error.body to aid in debugging. It should have no effect on normal usage.