This repository was archived by the owner on Apr 17, 2026. It is now read-only.
chore(simplify): simplify recent changes in qurl-reverse-proxy#7
Open
justin-layerv wants to merge 1 commit into
Open
chore(simplify): simplify recent changes in qurl-reverse-proxy#7justin-layerv wants to merge 1 commit into
justin-layerv wants to merge 1 commit into
Conversation
…try points - Extract duplicate printBanner() and ANSI color constants into pkg/banner - Rename cryptic variable `a` to `udpAgent` in nhpAgentStart - Eliminate duplicate getConfigFile() call in frpc main() - Extract hasConfigFlag() helper to avoid duplicated flag-scanning loop - Remove unnecessary named return in runServer() - Reuse exeBinDir for public dir path instead of redundant os.Executable() call Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printBanner()and ANSI color constants from duplicated definitions in both client and server entry pointsa→udpAgent, consolidate duplicategetConfigFile()calls, extracthasConfigFlag()helper, reuseexeBinDirfor public dir pathbanner.Print(), remove duplicate color constants and banner function, remove unnecessary named return inrunServer()Notes
cmd/frpccannot compile due to missingthird_party/opennhp/nhpdirectory (transitive dependency). This is unrelated to these changes.cmd/frpsandpkg/packages compile and passgo vetcleanly.go vetandgofmtTest plan
go vet ./pkg/...andgo vet ./cmd/frps/passgofmt -lreports no formatting issues🤖 Generated with Claude Code