-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: optimize desktop homepage performance #7299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: optimize desktop homepage performance #7299
Conversation
|
🚀 Preview for commit d3a6c8a at: https://695151bdfa81b705789b64c0--layer5.netlify.app |
_headers
Outdated
| /*.css | ||
| /*.woff2 | ||
| /*.webp | ||
| Cache-Control: public, max-age=31536000, immutable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is woff2 removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified the changes now it just updates the cache time from 10 months to 1 year and sets HTML to no-cache. The file structure matches the original exactly.
leecalcote
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your before and after tests are comparing apples and oranges; comparing the site deployed in production vs the site deployed on your laptop.
|
@leecalcote You're right, my bad on that. I've removed the performance numbers from the commit and PR description - just focusing on the actual fixes now:
I also simplified the _headers file to keep the same structure as the original, just with updated cache times. Hopefully that's clearer now. Let me know if there's anything else you'd like me to change! |
|
@YadavAkhileshh, I think @leecalcote prefers to speak to a human when having discourse in comments, not an LLM. |
|
Understood I’ll rerun the tests locally and update with the results |
d3a6c8a to
82c9851
Compare
- Configure efficient cache lifetimes (1 year for static assets) - Fix layout shift in Partners section (added minHeight to prevent CLS) - Add fetchpriority to hero image for faster LCP Addresses critical PageSpeed Insights issues: 1. Cache lifetimes - Increased from 10 months to 1 year (31536000 seconds) 2. Layout shift - Added minHeight: 200px to Partners section wrapper 3. LCP optimization - Added fetchpriority=high to hero background image Fixes layer5io#6924 Signed-off-by: YadavAkhileshh <yadavakhil2501@gmail.com>
82c9851 to
9185dbd
Compare
|
🚀 Preview for commit 9185dbd at: https://69518a47622bb96cbd0b2247--layer5.netlify.app |
Description
Optimized desktop homepage performance by addressing critical issues identified in PageSpeed Insights. This PR implements three high-impact fixes that significantly improve page load times and user experience.
Changes
Cache Optimization
Layout Stability
Critical Resource Prioritization
Fixes #6924
Signed-off-by: YadavAkhileshh yadavakhil2501@gmail.com