Skip to content

Conversation

@Katotodan
Copy link
Contributor

Description
On https://layer5.io/solutions/developer-defined-infrastructure page, at Design Architecture Diagram section and Orchestration Management section, on small devices the columns order should be reverted.
The image is first displayed following by the section's title and small description.
This PR aims to fix that.

This PR fixes ##7292

Notes for Reviewers

He are images before changes
Screenshot 2025-12-27 at 14 11 37
Screenshot 2025-12-27 at 14 12 52

  • And here are images after making some changes
Screenshot 2025-12-27 at 14 50 03 Screenshot 2025-12-27 at 14 50 17

Signed commits

  • [x ] Yes, I signed my commits.

Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
@l5io
Copy link
Contributor

l5io commented Dec 27, 2025

🚀 Preview for commit ae9cf0a at: https://694fcc40ba893177390835d8--layer5.netlify.app

@saurabhraghuvanshii
Copy link
Contributor

@Katotodan some cards are breaking on mobile view
Screenshot_2025-12-27-23-54-39-867_com android chrome

Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
@l5io
Copy link
Contributor

l5io commented Dec 28, 2025

🚀 Preview for commit 11ddaad at: https://69513629e2c7fac18b5b1303--layer5.netlify.app


import React from "react";
import React, { useRef, useState, useLayoutEffect } from "react";
// NOTE: useLayoutEffect is used intentionally here (instead of useEffect) so
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katotodan remove comments Please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhraghuvanshii should I all the comments I added, or just the one you pointed out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katotodan All comments keep code clean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhraghuvanshii I have deleted all the comments I added. There is still some code commented but those lines of code were there before I started to contribute on that section.

@l5io
Copy link
Contributor

l5io commented Dec 28, 2025

🚀 Preview for commit 62b1767 at: https://69513a3afe3f1e15d407d3ef--layer5.netlify.app

Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
@l5io
Copy link
Contributor

l5io commented Dec 28, 2025

🚀 Preview for commit fc8ee56 at: https://695141fd96fad8d30f2f7f1a--layer5.netlify.app

@saurabhraghuvanshii
Copy link
Contributor

@Katotodan order of image is never a issue. I would suggest you to revert order change and your card change is good so keep that

…ures.js

Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
@l5io
Copy link
Contributor

l5io commented Dec 28, 2025

🚀 Preview for commit 0cb6b4c at: https://6951521afe3f1e556707d4c3--layer5.netlify.app

@Katotodan
Copy link
Contributor Author

@saurabhraghuvanshii I have reverted the order of image to it initial state.

@saurabhraghuvanshii saurabhraghuvanshii merged commit 59f55e1 into layer5io:master Dec 28, 2025
4 checks passed
@saurabhraghuvanshii
Copy link
Contributor

Thanks @Katotodan lgtm!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants