-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: fixing the columns order on small devices #7293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixing the columns order on small devices #7293
Conversation
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
|
🚀 Preview for commit ae9cf0a at: https://694fcc40ba893177390835d8--layer5.netlify.app |
|
@Katotodan some cards are breaking on mobile view |
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
|
🚀 Preview for commit 11ddaad at: https://69513629e2c7fac18b5b1303--layer5.netlify.app |
|
|
||
| import React from "react"; | ||
| import React, { useRef, useState, useLayoutEffect } from "react"; | ||
| // NOTE: useLayoutEffect is used intentionally here (instead of useEffect) so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Katotodan remove comments Please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saurabhraghuvanshii should I all the comments I added, or just the one you pointed out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Katotodan All comments keep code clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saurabhraghuvanshii I have deleted all the comments I added. There is still some code commented but those lines of code were there before I started to contribute on that section.
|
🚀 Preview for commit 62b1767 at: https://69513a3afe3f1e15d407d3ef--layer5.netlify.app |
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
|
🚀 Preview for commit fc8ee56 at: https://695141fd96fad8d30f2f7f1a--layer5.netlify.app |
|
@Katotodan order of image is never a issue. I would suggest you to revert order change and your card change is good so keep that |
…ures.js Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
|
🚀 Preview for commit 0cb6b4c at: https://6951521afe3f1e556707d4c3--layer5.netlify.app |
|
@saurabhraghuvanshii I have reverted the order of image to it initial state. |
|
Thanks @Katotodan lgtm!! |

Description
On https://layer5.io/solutions/developer-defined-infrastructure page, at Design Architecture Diagram section and Orchestration Management section, on small devices the columns order should be reverted.
The image is first displayed following by the section's title and small description.
This PR aims to fix that.
This PR fixes ##7292
Notes for Reviewers
He are images before changes


Signed commits