refactor(errors): remove SubCategoryUserError — charge normal CU for …#2273
Merged
nimrod-teich merged 1 commit intomainfrom Apr 16, 2026
Merged
refactor(errors): remove SubCategoryUserError — charge normal CU for …#2273nimrod-teich merged 1 commit intomainfrom
nimrod-teich merged 1 commit intomainfrom
Conversation
NadavLevi
force-pushed
the
refactor/remove-user-error-subcategory
branch
2 times, most recently
from
ed683ed to
376c082
Compare
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…user-input errors User-input errors (Layer D: invalid params, bad hex, parse errors) were previously zero-CU like unsupported-method errors. This was wrong because user-error responses are NOT cached — the provider does real work on every call and should be compensated. Only unsupported-method responses (which ARE cached) justify the zero-CU carve-out. - Remove SubCategoryUserError, IsUserError(), IsNonRetryableUserFacing() - Remove IsUserInputError() classifier function - Remove IsUserError field from RelayResult and NodeErrorClassification - Remove IsNonRetryableUserFacingErrorType() (now redundant) - Layer D codes keep Retryable=false (no retry) but SubCategory=None (normal CU) - Zero-CU gate simplified: only IsUnsupportedMethod triggers it - HasNonRetryableUserFacingErrors now uses IsNonRetryable flag directly Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NadavLevi
force-pushed
the
refactor/remove-user-error-subcategory
branch
from
376c082 to
56a1e29
Compare
AnnaR-prog
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…user-input errors
User-input errors (Layer D: invalid params, bad hex, parse errors) were previously zero-CU like unsupported-method errors. This was wrong because user-error responses are NOT cached — the provider does real work on every call and should be compensated. Only unsupported-method responses (which ARE cached) justify the zero-CU carve-out.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...