perf(chainlib): zero-copy passthrough in checkUTXOResponseAndFixReply…#2269
Merged
nimrod-teich merged 1 commit intomainfrom Apr 16, 2026
Merged
perf(chainlib): zero-copy passthrough in checkUTXOResponseAndFixReply…#2269nimrod-teich merged 1 commit intomainfrom
nimrod-teich merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
avitenzer
reviewed
Apr 15, 2026
… for non-UTXO chains The function unconditionally did `string(replyData)` on entry, which allocated a full copy of every upstream reply body — even for non-UTXO chains that then returned immediately without using it. A live pprof capture on the eth router attributed ~4.5 GB of inuse memory over a 12-minute window to this single allocation. Return []byte and only reformat on the UTXO path; non-UTXO chains (ETH, Cosmos, tendermint, etc.) now pass through the original slice with no copy. Test coverage adds a pointer-identity assertion so any future regression that reintroduces an eager copy fails loudly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NadavLevi
force-pushed
the
perf/utxo-response-bytes-passthrough
branch
from
4d97402 to
666c1a4
Compare
avitenzer
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… for non-UTXO chains
The function unconditionally did
string(replyData)on entry, which allocated a full copy of every upstream reply body — even for non-UTXO chains that then returned immediately without using it. A live pprof capture on the eth router attributed ~4.5 GB of inuse memory over a 12-minute window to this single allocation.Return []byte and only reformat on the UTXO path; non-UTXO chains (ETH, Cosmos, tendermint, etc.) now pass through the original slice with no copy. Test coverage adds a pointer-identity assertion so any future regression that reintroduces an eager copy fails loudly.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...