Fix memory leak and autosave not working in mobile devices after showing all running apps and returning - #85
Merged
Conversation
lauslim12
changed the title
lauslim12
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is due to subscribing to the store in the root of the application instead of at the
useEffect. Very subtle.Also, autosave is not working in an edge case: use a phone, write something, get it to autosave, use the "Show All Running Apps" feature, go back to the application, try to write something, the autosave does not work anymore. I've fixed that in 290eb48 and written a test in 8817ed2 to prevent it from happening again.