feat: Add archived field to launchdarkly_metrics resources#347
Closed
sasthana-ld wants to merge 1 commit into
Closed
feat: Add archived field to launchdarkly_metrics resources#347sasthana-ld wants to merge 1 commit into
sasthana-ld wants to merge 1 commit into
Conversation
Signed-off-by: Siddharth Asthana <sasthana@launchdarkly.com>
ember-stevens
approved these changes
Sep 2, 2025
Contributor
ember-stevens
left a comment
There was a problem hiding this comment.
✅ from Docs for the copy
Author
|
Ah closing this as created this PR from wrong branch name (didn't follow the JIRA steps to generate the branch and PR) closing this against #348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
archivedboolean field tolaunchdarkly_metricresource to allow users to mark metrics as archived through Terraform.added TO-DO comments for api client since
ldapi.MetricPostdoes not supportArchivedfield yet so when LD api client is merged I will uncomment the archived field code in create/update operationsmade changes as we have discussed in Tech spec: https://docs.google.com/document/d/1HKRRgdSnHoXjrLnzRY9_7hQw4Q5pW9Q_AQdpO0wTm9w/edit?tab=t.0#heading=h.lcgpt7k0oisq
Jira Ticket: https://launchdarkly.atlassian.net/browse/MTRX-1308
Wait!
Testing
For any changes you make, please ensure your acceptance test conform to the following:
ImportStateandImportStateVerifyare set to true.ImportStateVerifyIgnorecan be used if we explicitly expect a value to be different when imported, such as in the case of obfuscated values like API keysLaunchDarkly Employees
For more information on how to build, test, and release, see the internal provider runbook.