[Cursor] feat: optional GitHub Action dockerImage entry point - #610
Closed
tknopp-ld wants to merge 1 commit into
Closed
[Cursor] feat: optional GitHub Action dockerImage entry point#610tknopp-ld wants to merge 1 commit into
tknopp-ld wants to merge 1 commit into
Conversation
Add launchdarkly/find-code-references/docker composite Action so workflows can pull the scanner image from a private registry or Docker Hub proxy without changing the root Docker Action used by existing workflows. Co-authored-by: Cursor <cursoragent@cursor.com>
tknopp-ld
force-pushed
the
feat/frops-410-docker-image-override
branch
from
August 5, 2026 15:00
8391bc5 to
5add353
Compare
Author
|
Superseded by #611 (branch renamed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launchdarkly/find-code-references/dockerwith adockerImageinput so workflows can pull the scanner from a private registry or Docker Hub proxy.action.yml+Dockerfile) unchanged so existinguses: launchdarkly/find-code-references@v2workflows keep the current GitHub-managed runtime.GITHUB_WORKSPACE,GITHUB_EVENT_PATH, anddockerCLI; release copy script now preserves nested metadata (docker/).Why not change the root Action
GitHub does not allow dynamic
runs.image/${{ inputs.* }}onusing: dockerActions (docs, SO).Usage (after publish to find-code-references)
Test plan
Composite +
docker runcan fail quietly (green CI, wrong/empty data in LD) if mounts or env are wrong. Test on a real GitHub-hosted runner (not onlyact), against a repo that already has known flag refs in LD.0. Hygiene
git diff main -- build/metadata/github-actions/action.yml Dockerfileis empty (root Action unchanged)cp -a build/metadata/github-actions/. /tmp/fcr-test/includesdocker/action.yml1. Baseline parity (default Hub image)
Workflow A —
/dockerwith nodockerImage(uses default Hub tag):Workflow B — same job, root Action (control):
Assert:
GITHUB_EVENT_PATH/ workspace fail-fasts do not fireFailure modes this catches: missing workspace mount (empty scan), missing event/ref (wrong branch).
2. Explicit Hub URI
dockerImage: launchdarkly/ld-find-code-refs-github-action:2.16.0explicitly — same results as §13. Mirrored registry
docker/login-actionthen/dockerwithdockerImage: <mirror URI>Failure modes this catches: login ordering, wrong image tag, private pull auth.
4. Lookback / extinctions (git history in the container)
fetch-depth: 11,lookback: 10(defaults).gitFailure modes this catches: workspace mount without
.git, shallow-clone mismatch.5. Defaults parity vs CLI footguns
pruneinput — confirm behavior matches root Action (prunefalse), not CLI default true (check logs: should not attempt remote prune on a private repo unless enabled)lookback/contextLinesbehave like root defaults6. Negative / fail-loud checks (should be red, not silent)
GITHUB_WORKSPACEerrordockerImage: ""— step fails with empty-image error7. Exit codes
accessToken/ unreachable API withignoreServiceErrors: false— non-zero exit (not swallowed by the composite wrapper)ignoreServiceErrors: true— still respects scanner behavior (exit 0 on service errors)8. Release follow-up
docker/intolaunchdarkly/find-code-references, tag (e.g.v2.17.0)uses: launchdarkly/find-code-references/docker@...(not local path)