chore: typo in release workflow - #595
Merged
Merged
Conversation
Add missing closing quote in ssm_parameter_pairs
cspath1
approved these changes
Jan 27, 2026
nieblara
changed the title
apucacao
added a commit
that referenced
this pull request
Jul 28, 2026
## Summary Prepares the 2.16.0 release by hand. This is the same approach taken for 2.14.0 in #563: the release workflow can publish artifacts but cannot complete a release, so the version bump lands as a normal PR and the tag, GitHub release, and downstream action update are done manually afterward. Related to #607 — the fix being asked for there is #604. That issue stays open until the release and the downstream action update are actually out. ## Why by hand `scripts/release/prepare-release.sh` commits the version bump and changelog entry, then `push-to-origin.sh` pushes that commit straight to `main`. Rulesets reject it: ``` remote: error: GH013: Repository rule violations found for refs/heads/main remote: - Changes must be made through a pull request. ! [remote rejected] HEAD -> main ``` This has now failed the same way three times: August 2025 (worked around manually in #563), January 2026 (#593–#595, which disabled the GHA/Bitbucket/CircleCI publish targets to get a Docker-only release out), and again today. The plan stated in #563 was to move to Release Please so that releasing never pushes to `main`. That hasn't happened yet, so this PR follows the manual path again. ## What changed | File | Change | | --- | --- | | `internal/version/version.go` | `2.14.0` → `2.16.0` | | `CHANGELOG.md` | 2.16.0 entry, plus a note that 2.15.0 was never released | | `build/metadata/github-actions/Dockerfile` | image tag → `2.16.0` | | `build/metadata/github-actions/README.md` | `find-code-references@v2.16.0` | ## Behavior notes - **Numbering skips 2.15.0.** January's run pushed `ld-find-code-refs:2.15.0` and `ld-find-code-refs-github-action:2.15.0` to Docker Hub before failing, so those tags are already taken. Releasing as 2.16.0 keeps published images immutable. - **Docker images for 2.16.0 are already published.** Today's run got as far as `publish` before failing, so `2.16.0` and `latest` are on Docker Hub, built from `d2b674b` with the version constant patched to 2.16.0. - **`brew install ld-find-code-refs` is broken right now.** That same run updated the homebrew tap formula to 2.16.0, but its download URLs point at release assets that don't exist yet. Creating the GitHub release fixes it; the shas need regenerating because the assets will come from a local build rather than the CI build. - **Bitbucket and CircleCI metadata deliberately untouched.** Those targets stopped being published in January, so bumping them would name a pipe version and orb version that were never cut. ## Testing `go build ./...` and `go test ./aliases/...` pass. Nothing here is executable code beyond the version constant. ## Provenance Rebuilt as two narrative commits on `release-2.16.0-clean`; the original branch is [`release-2.16.0`](https://github.com/launchdarkly/ld-find-code-refs/tree/release-2.16.0). Tree hashes verified identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in the release workflow where a closing quote was missing in the
ssm_parameter_pairsparameter.