style(components): improve dark-mode Modal and Popover differentiation#1943
Merged
Merged
Conversation
Co-Authored-By: rhalloran@launchdarkly.com <rhalloran@launchdarkly.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: 884aa60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
nhironaka
approved these changes
Jul 8, 2026
rapha-ld
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In dark themes,
ModalandPopoversurfaces don't separate clearly enough from the background. This adds a subtle border plus a deeper drop shadow and a hairline ring to both, scoped to dark themes vialight-dark()so light themes are unchanged.Applied to
packages/components/src/styles/Modal.module.css(.base) andpackages/components/src/styles/Popover.module.css(.popover):Token mapping (requested raw values → closest Launchpad tokens):
1px solid rgba(255,255,255,0.08)→var(--lp-color-border-ui-primary)(semantic border token; adapts per theme)0 20px 60px rgba(0,0,0,0.5)→var(--lp-color-black-500)=rgba(7,8,12,0.5)0 0 0 1px rgba(255,255,255,0.05)→var(--lp-color-white-0)=rgba(255,255,255,0.05)(exact)light-dark()follows the existing pattern inPopover.module.css(the arrow stroke), keying offcolor-schemeso it resolves correctly for portaled overlays.Screenshots:
Before:

After:

Testing approaches
pnpm check(Biome) clean on the changed files.Link to Devin session: https://app.devin.ai/sessions/b4f9e99abc124a99bdcc5918b09ae387
Note
Low Risk
Visual-only CSS token changes on overlay surfaces; no logic, API, or data-path changes.
Overview
Dark themes get clearer separation for Modal (
.base) and Popover (.popover) overlays via theme-scoped styling only: a1pxborder usingvar(--lp-color-border-ui-primary), plus two extrabox-shadowlayers (deeper drop shadow withvar(--lp-color-black-500)and a 1px hairline ring withvar(--lp-color-white-0)). Existing shadow layers are kept; new values uselight-dark(transparent, …)so light mode stays unchanged, matching the existinglight-dark()usage on Popover arrows.A patch changeset documents the
@launchpad-ui/componentsrelease note.Reviewed by Cursor Bugbot for commit 884aa60. Bugbot is set up for automated code reviews on this repo. Configure here.