-
Notifications
You must be signed in to change notification settings - Fork 34
feat: Add FDv2 DataManager and enable experimental FDv2 support. #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kinyoklion
wants to merge
34
commits into
main
Choose a base branch
from
mk/NOTICKET/testing-fdv2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
cb14960
feat: Add experimental FDv2 configuration (unused)
kinyoklion 9f88376
refactor: Use compound validator for dataSystem with built-in defaults
kinyoklion a90b962
fix: Lint fixes for dataSystem configuration
kinyoklion fa111d5
Merge branch 'main' into rlamb/SDK-1935/FDv2-configuration
kinyoklion 73c6f2a
WIP: Example of this working together
keelerm84 109aeea
Fix interrupted state for non-status codes.
kinyoklion e7f5049
Tests
kinyoklion e2821cd
Fix basis.
kinyoklion a7413c0
rebase data system config
kinyoklion e40b0d5
Integrate mode switching and caching.
kinyoklion 7bfa7ac
Merge branch 'main' into mk/NOTICKET/testing-fdv2
kinyoklion e2b7d15
Streaming control interface
kinyoklion 9d242d4
Skip cache when bootstrap is available.
kinyoklion cee85ee
Add event flush on backgrounding.
kinyoklion 0d92a78
remove flag_eval support; use flag-eval only
keelerm84 5ee0469
Merge branch 'main' into mk/NOTICKET/testing-fdv2
kinyoklion cfc1207
Remove debug logging from FDv2DataSource.
kinyoklion ea3eb1d
Commonize stream control input between browser and RN for FDv2.
kinyoklion 67eff51
Merge branch 'main' into mk/NOTICKET/testing-fdv2
kinyoklion 4f59d39
Increase package size limits
kinyoklion c603f56
Don't export internals
kinyoklion 2a80fa7
Better type alignment
kinyoklion 4eb5a59
Stricter validation and logging.
kinyoklion 3e287df
Merge branch 'main' into mk/NOTICKET/testing-fdv2
kinyoklion bd80512
Remove browser specific data manager.
kinyoklion 4824560
Add cache comment
kinyoklion 304e5f3
Ensure streaming is off when setStreaming(false)
kinyoklion 0a03954
Fix mode switching.
kinyoklion 0d1b333
contract test changes - wip
tanderson-ld 88ab6a4
Additional handling.
kinyoklion 70bdf7d
Merge remote-tracking branch 'origin/mk/NOTICKET/testing-fdv2' into m…
kinyoklion 04d2644
Connect withReasons.
kinyoklion 6c1996d
Allow mode customization. Connect withReasons.
kinyoklion 266104a
Trim failing tests.
kinyoklion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
packages/sdk/browser/contract-tests/suppressions_datamode_changes.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| streaming/requests/method and headers/REPORT/http | ||
| streaming/requests/URL path is computed correctly/no environment filter/base URI has no trailing slash/REPORT | ||
| streaming/requests/URL path is computed correctly/no environment filter/base URI has a trailing slash/REPORT | ||
| streaming/requests/query parameters/evaluationReasons set to [none]/REPORT | ||
| streaming/requests/query parameters/evaluationReasons set to false/REPORT | ||
| streaming/requests/query parameters/evaluationReasons set to true/REPORT | ||
| streaming/requests/context properties/single kind minimal/REPORT | ||
| streaming/requests/context properties/single kind with all attributes/REPORT | ||
| streaming/requests/context properties/multi-kind/REPORT | ||
| polling/requests/method and headers/REPORT/http | ||
| polling/requests/URL path is computed correctly/no environment filter/base URI has no trailing slash/REPORT | ||
| polling/requests/URL path is computed correctly/no environment filter/base URI has a trailing slash/REPORT | ||
| polling/requests/query parameters/evaluationReasons set to [none]/REPORT | ||
| polling/requests/query parameters/evaluationReasons set to false/REPORT | ||
| polling/requests/query parameters/evaluationReasons set to true/REPORT | ||
| polling/requests/context properties/single kind minimal/REPORT | ||
| polling/requests/context properties/single kind with all attributes/REPORT | ||
| polling/requests/context properties/multi-kind/REPORT | ||
| tags/stream requests/{"applicationId":null,"applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"} | ||
| tags/stream requests/{"applicationId":null,"applicationVersion":"________________________________________________________________"} | ||
| tags/stream requests/{"applicationId":"","applicationVersion":null} | ||
| tags/stream requests/{"applicationId":"","applicationVersion":""} | ||
| tags/stream requests/{"applicationId":"","applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"} | ||
| tags/stream requests/{"applicationId":"","applicationVersion":"________________________________________________________________"} | ||
| tags/stream requests/{"applicationId":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678","applicationVersion":null} | ||
| tags/stream requests/{"applicationId":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678","applicationVersion":""} | ||
| tags/stream requests/{"applicationId":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678","applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"} | ||
| tags/stream requests/{"applicationId":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678","applicationVersion":"________________________________________________________________"} | ||
| tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":null} | ||
| tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":""} | ||
| tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"} | ||
| tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":"________________________________________________________________"} | ||
| tags/poll requests/{"applicationId":null,"applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"} | ||
| tags/poll requests/{"applicationId":null,"applicationVersion":"________________________________________________________________"} | ||
| tags/poll requests/{"applicationId":"","applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"} | ||
| tags/poll requests/{"applicationId":"","applicationVersion":"________________________________________________________________"} | ||
| tags/poll requests/{"applicationId":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678","applicationVersion":null} | ||
| tags/poll requests/{"applicationId":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678","applicationVersion":""} | ||
| tags/poll requests/{"applicationId":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678","applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"} | ||
| tags/poll requests/{"applicationId":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678","applicationVersion":"________________________________________________________________"} | ||
| tags/poll requests/{"applicationId":"________________________________________________________________","applicationVersion":null} | ||
| tags/poll requests/{"applicationId":"________________________________________________________________","applicationVersion":""} | ||
| tags/poll requests/{"applicationId":"________________________________________________________________","applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"} | ||
| tags/poll requests/{"applicationId":"________________________________________________________________","applicationVersion":"________________________________________________________________"} | ||
| tags/disallowed characters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,69 @@ | ||
| body { | ||
| margin: 0; | ||
| padding: 20px; | ||
| background: #373841; | ||
| color: white; | ||
| font-family: | ||
| -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', | ||
| 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif; | ||
| -webkit-font-smoothing: antialiased; | ||
| -moz-osx-font-smoothing: grayscale; | ||
| text-align: center; | ||
| } | ||
|
|
||
| #status { | ||
| padding: 10px; | ||
| margin-bottom: 10px; | ||
| background: rgba(255,255,255,0.1); | ||
| border-radius: 4px; | ||
| } | ||
|
|
||
| #flag { | ||
| font-size: 1.4em; | ||
| padding: 15px; | ||
| margin-bottom: 20px; | ||
| background: rgba(255,255,255,0.05); | ||
| border-radius: 4px; | ||
| } | ||
|
|
||
| #controls { | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: 15px; | ||
| } | ||
|
|
||
| #controls > div { | ||
| padding: 10px; | ||
| background: rgba(255,255,255,0.05); | ||
| border-radius: 4px; | ||
| } | ||
|
|
||
| #controls h3 { | ||
| margin: 0 0 8px 0; | ||
| font-size: 0.9em; | ||
| text-transform: uppercase; | ||
| opacity: 0.7; | ||
| } | ||
|
|
||
| button { | ||
| padding: 6px 14px; | ||
| margin: 3px 2px; | ||
| border: 1px solid rgba(255,255,255,0.3); | ||
| border-radius: 4px; | ||
| background: rgba(255,255,255,0.1); | ||
| color: white; | ||
| cursor: pointer; | ||
| font-size: 0.9em; | ||
| } | ||
|
|
||
| button:hover { | ||
| background: rgba(255,255,255,0.2); | ||
| } | ||
|
|
||
| #log { | ||
| max-height: 200px; | ||
| overflow-y: auto; | ||
| font-family: monospace; | ||
| font-size: 0.8em; | ||
| line-height: 1.5; | ||
| opacity: 0.8; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now all the size limits are 10% over the size of the packages in this PR.
After we have everything assembled we can do another pass to decrease size. Most of the size changes probably won't be related to the changes in this PR itself.
We already know that we have some barrel related problems with
internaland it is time to fix the server-side exports.