Skip to content

chore: Bump golangci-lint to v2.11.1#357

Merged
keelerm84 merged 2 commits intov7from
devin/1773088690-bump-golangci-lint
Mar 10, 2026
Merged

chore: Bump golangci-lint to v2.11.1#357
keelerm84 merged 2 commits intov7from
devin/1773088690-bump-golangci-lint

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 9, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Part of a broader effort to bump golangci-lint across LaunchDarkly Go repositories, matching ld-relay#586.

Describe the solution you've provided

Bumps golangci-lint from v2.9.0 to v2.11.1 in the Makefile and removes an unused //nolint:gosec directive in ldhttp/http_transport.go.

The nolint:gosec directive on the tls.Config{RootCAs: ...} line was flagged as unused by nolintlint in v2.11.1 — gosec no longer reports an issue for a tls.Config that only sets RootCAs (Go's default MinVersion is already TLS 1.2+, which is considered secure).

Describe alternatives you've considered

N/A — this is a straightforward tooling version bump.

Additional context

Items for human review

  • Verify that removing the //nolint:gosec directive on ldhttp/http_transport.go:193 is safe. The rationale is that gosec no longer flags tls.Config{RootCAs: caCerts} without an explicit MinVersion, since modern Go defaults to TLS 1.2+. If there's a policy reason to keep the directive as documentation, it can be restored.

Link to Devin session: https://app.devin.ai/sessions/45faa2d1c22c41c6beab7ce8e891bc96
Requested by: @keelerm84


Note

Low Risk
Tooling-only update plus removal of an unused lint suppression; no runtime behavior changes expected beyond lint results.

Overview
Bumps golangci-lint from v2.9.0 to v2.11.1 via the Makefile linter version pin.

Removes an unused //nolint:gosec comment from ldhttp/http_transport.go where tls.Config{RootCAs: ...} is set, aligning with the newer linter’s checks.

Written by Cursor Bugbot for commit 775517a. This will update automatically on new commits. Configure here.

devin-ai-integration bot and others added 2 commits March 9, 2026 20:44
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@keelerm84 keelerm84 marked this pull request as ready for review March 10, 2026 12:25
@keelerm84 keelerm84 requested a review from a team as a code owner March 10, 2026 12:25
@keelerm84 keelerm84 merged commit ef9846a into v7 Mar 10, 2026
47 of 48 checks passed
@keelerm84 keelerm84 deleted the devin/1773088690-bump-golangci-lint branch March 10, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants