Merged
Conversation
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
keelerm84
approved these changes
Mar 9, 2026
keelerm84
approved these changes
Mar 10, 2026
jsonbailey
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Part of a broader effort to bump golangci-lint across LaunchDarkly Go repositories, matching ld-relay#586.
Describe the solution you've provided
Bumps
golangci-lintfrom v2.9.0 to v2.11.1 in the Makefile and removes an unused//nolint:gosecdirective inldhttp/http_transport.go.The
nolint:gosecdirective on thetls.Config{RootCAs: ...}line was flagged as unused bynolintlintin v2.11.1 —gosecno longer reports an issue for atls.Configthat only setsRootCAs(Go's defaultMinVersionis already TLS 1.2+, which is considered secure).Describe alternatives you've considered
N/A — this is a straightforward tooling version bump.
Additional context
Items for human review
//nolint:gosecdirective onldhttp/http_transport.go:193is safe. The rationale is thatgosecno longer flagstls.Config{RootCAs: caCerts}without an explicitMinVersion, since modern Go defaults to TLS 1.2+. If there's a policy reason to keep the directive as documentation, it can be restored.Link to Devin session: https://app.devin.ai/sessions/45faa2d1c22c41c6beab7ce8e891bc96
Requested by: @keelerm84
Note
Low Risk
Tooling-only update plus removal of an unused lint suppression; no runtime behavior changes expected beyond lint results.
Overview
Bumps
golangci-lintfromv2.9.0tov2.11.1via theMakefilelinter version pin.Removes an unused
//nolint:goseccomment fromldhttp/http_transport.gowheretls.Config{RootCAs: ...}is set, aligning with the newer linter’s checks.Written by Cursor Bugbot for commit 775517a. This will update automatically on new commits. Configure here.