feat: Support combining multi-contexts using ldcontext:new_multi_from. #167
+109
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
force-pushed
the
rlamb/sdk-244385/multi-context-merging
branch
from
0ee2c24 to
5f7479c
Compare
kinyoklion
commented
Feb 9, 2026
| case maps:size(MultiContext) of | ||
| 2 -> | ||
| %% One kind plus 'kind' key - convert back to single context. | ||
| [SingleKind] = get_kinds(MultiContext), |
Member
Author
There was a problem hiding this comment.
{
kind => <<"multi">>,
<<"user">> => #{}
}
{
kind => <<"multi">>,
<<"user">> => #{},
<<"organization">> => #{}
}
kinyoklion
commented
Feb 9, 2026
| 2 -> | ||
| %% One kind plus 'kind' key - convert back to single context. | ||
| [SingleKind] = get_kinds(MultiContext), | ||
| #{SingleKind := ContextPart} = MultiContext, |
Member
Author
There was a problem hiding this comment.
[<<"user">>]
SingleKind = <<"user">>
#{SingleKind := ContextPart} = MultiContext
#{<<"user">> := ContextPart} = #{ <<"user">> => #{}}
JS
ContextPart = MultiContext["user"];
ContextPart["kind"] = "multi"
keelerm84
approved these changes
Feb 9, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Feb 9, 2026
🤖 I have created a release *beep* *boop* --- ## [3.9.0](v3.8.1...v3.9.0) (2026-02-09) ### Features * Support combining multi-contexts using ldcontext:new_multi_from. ([#167](#167)) ([7c9f934](7c9f934)), closes [#126](#126) ### Bug Fixes * Fix an issue where <<kind>> would be included in the list of context kinds when kind was binary. ([#168](#168)) ([8cdee5c](8cdee5c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates ldclient:new_multi_from to support merging single and multi-kind contexts into a single multi-kind context.
Fixes: #126