Skip to content

ci: require a driving Issue to merge (PR hygiene) - #1

Merged
mollusk merged 6 commits into
masterfrom
chore/pr-github-hygiene
Aug 22, 2026
Merged

mollusk merged 6 commits into
masterfrom
chore/pr-github-hygiene

Conversation

@mollusk

@mollusk mollusk commented Aug 22, 2026

Copy link
Copy Markdown
Member

Fixes https://github.com/lassoanalytics/cursor-config/issues/359

Summary

  • Add pr-github-hygiene: PR must have Fixes #N on line 1 and a Development-linked Issue, or label skip-issue-link.
  • Required-on-default is applied only after this file is on the default branch.

Copilot AI balanced review requested due to automatic review settings August 22, 2026 02:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions check enforcing issue-linking hygiene for pull requests.

Changes:

  • Validates the PR body’s closing-issue reference.
  • Requires a Development-linked issue or bypass label.
  • Reports actionable workflow errors.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/pr-github-hygiene.yml
Comment thread .github/workflows/pr-github-hygiene.yml
@lasso-roger

Copy link
Copy Markdown
Collaborator

Roger is addressing 2 unresolved Copilot review threads on this PR (running /pr).

Cursor agent: https://cursor.com/agents/bc-4ea70d06-5ee0-4507-a0f7-e7066760aadb

cursoragent and others added 4 commits August 22, 2026 02:04
- first_line() now inspects physical line 1 instead of skipping blank lines
- Fetch up to 100 labels so skip-issue-link bypass works reliably

Co-authored-by: Andrew Fiebert <mollusk@users.noreply.github.com>
GITHUB_TOKEN cannot read cross-repo closingIssuesReferences; trust
org/repo#N and github.com/.../issues/N on physical line 1 as fallback.

Co-authored-by: Andrew Fiebert <mollusk@users.noreply.github.com>
- first_line() inspects physical line 1 instead of skipping blank lines
- Fetch up to 100 labels so skip-issue-link bypass works reliably

Co-authored-by: Andrew Fiebert <mollusk@users.noreply.github.com>
@lasso-roger

Copy link
Copy Markdown
Collaborator

@mollusk — Copilot PR review threads on this PR are resolved. Roger addressed the feedback (via /pr).

  • Cursor agent bc-4ea70d06-5ee0-4507-a0f7-e7066760aadb → FINISHED

@mollusk
mollusk merged commit 3e0fcf5 into master Aug 22, 2026
1 check failed
@mollusk
mollusk deleted the chore/pr-github-hygiene branch August 22, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants