only add js (checked by hash) once#129
Open
morksinaanab wants to merge 1 commit intolaracasts:masterfrom
Open
Conversation
…ded through queued tasks adding more than once
morksinaanab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves issue #110
Queued tasks add the JS code multiple times. The fix keeps track of each js that is to be added with an array with hashes in the
$viewdata. If there already is a hash for the js code, skip it. It seems todo the trick.It's not really a solution to the problem that the queue is adding multiple (unnecessary) listeners, but it is a failsafe.