Fix distributed CSV comparison test#12
Open
yrasool wants to merge 146 commits into
Open
Conversation
Update CI See merge request hard/hard!6
Assert positive energy also for internal energy See merge request hard/hard!2
Fix for boundaries and add verification in CI See merge request hard/hard!1
Also removed bounds_error=False, it is not needed when given fill_value="extrapolate".
Added acoustic wave verification See merge request hard/hard!3
1) Added comments so each step is easier to follow 2) Reduced the verbosity of some variables so the code is easier to read 3) Removed unnecessary variables
Fixed bug in Heun's method See merge request hard/hard!4
Update CI upstream See merge request hard/hard!9
Fixed the rad issue See merge request hard/hard!40
Corrected v-cycle figure for accuracy See merge request hard/hard!41
Add Adaptive FLD for Radiation See merge request hard/hard!39
Add FleCSolve See merge request hard/hard!43
Add RT and fix action See merge request hard/hard!44
Add KH Radiation test See merge request hard/hard!45
Add Richtmyer Meshkov Test See merge request hard/hard!46
These are not all the fixes necessary, but they are the fixes that do not break v0.23, with which HARD is compatible.
Not needed since flecsi2.4
Fixes to the spack packages for v1 compatibility See merge request hard/hard!47
These changes are not compatible with spack v0.23
Non-compatible spack v1.0 changes See merge request hard/hard!49
Collaborator
|
We have huge changes of the code coming soon with a new Spack and a new structure for the different applications. I will wait for these changes to be pushed before merging this MR. I hope to push before the end of the month. Thank you! |
Collaborator
|
Sorry for the delay! The new version of the code is finally out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the distributed regression script so it compares the comma-separated CSV columns written by HARD instead of treating rows as tab-separated text.
Also removes noisy
lscalls and prints a unified diff when single-rank and distributed outputs differ.Testing:
bash -n app/tests/test_distributed.sh