feat(webapp-access): add WEBAPP_PUBLIC_ACCESS_ENABLED toggle#38567
Open
GareArc wants to merge 3 commits into
Open
feat(webapp-access): add WEBAPP_PUBLIC_ACCESS_ENABLED toggle#38567GareArc wants to merge 3 commits into
GareArc wants to merge 3 commits into
Conversation
Allows enterprise on-prem deployments to disable the "public" webapp access-mode choice in the console UI via an opt-out env var (default true). The flag is env-driven only, with no enterprise-server round trip, and existing apps already set to public keep displaying that mode; only future selection is blocked.
The deployments access-control dialog duplicated Infotip's Popover wiring almost verbatim. overlay.md sanctions Infotip for exactly this case; the base/* import ban targets modal/dialog/drawer, not Infotip.
GareArc
requested review from
QuantumGhost,
crazywoola,
douxc,
iamjoel,
laipz8200 and
lyzno1
as code owners
dosubot
Bot
added
size:M
Contributor
Pyrefly Type Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38567 +/- ##
==========================================
+ Coverage 85.34% 85.36% +0.01%
==========================================
Files 5013 5012 -1
Lines 265942 266059 +117
Branches 50558 50563 +5
==========================================
+ Hits 226980 227128 +148
+ Misses 34509 34479 -30
+ Partials 4453 4452 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESQ1-132. Adds
WEBAPP_PUBLIC_ACCESS_ENABLED(default true) to disable the "Public" webapp access-mode option when set false.