Skip to content

test: mock to sqlite3#38501

Draft
asukaminato0721 wants to merge 1 commit into
langgenius:mainfrom
asukaminato0721:mock-to-sqlite3-1
Draft

test: mock to sqlite3#38501
asukaminato0721 wants to merge 1 commit into
langgenius:mainfrom
asukaminato0721:mock-to-sqlite3-1

Conversation

@asukaminato0721

Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

#32454

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 7, 2026
@asukaminato0721 asukaminato0721 enabled auto-merge July 7, 2026 06:33
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-07-10 04:29:31.822090955 +0000
+++ /tmp/pyrefly_pr.txt	2026-07-10 04:29:22.194010065 +0000
@@ -1,3 +1,7 @@
+ERROR Could not find name `datetime` [unknown-name]
+  --> controllers/console/datasets/external.py:81:43
+ERROR Could not find name `datetime` [unknown-name]
+  --> controllers/console/datasets/external.py:82:30
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `dify_vdb_alibabacloud_mysql.alibabacloud_mysql_vector.AlibabaCloudMySQLVectorFactory.init_vector` [bad-argument-type]
   --> providers/vdb/vdb-alibabacloud-mysql/tests/unit_tests/test_alibabacloud_mysql_factory.py:42:38
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `dify_vdb_alibabacloud_mysql.alibabacloud_mysql_vector.AlibabaCloudMySQLVectorFactory.init_vector` [bad-argument-type]
@@ -7468,6 +7472,18 @@
    --> tests/unit_tests/services/retention/workflow_run/test_restore_archived_workflow_run.py:760:71
 ERROR `in` is not supported between `Literal['not found']` and `None` [not-iterable]
    --> tests/unit_tests/services/retention/workflow_run/test_restore_archived_workflow_run.py:907:16
+ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
+   --> tests/unit_tests/services/test_account_service.py:955:9
+ERROR Object of class `TestRegisterService` has no attribute `_create_tenant_with_inviter` [missing-attribute]
+    --> tests/unit_tests/services/test_account_service.py:1781:27
+ERROR Object of class `TestRegisterService` has no attribute `_create_tenant_with_inviter` [missing-attribute]
+    --> tests/unit_tests/services/test_account_service.py:1829:27
+ERROR Object of class `TestRegisterService` has no attribute `_create_tenant_with_inviter` [missing-attribute]
+    --> tests/unit_tests/services/test_account_service.py:1879:27
+ERROR Object of class `TestRegisterService` has no attribute `_create_tenant_with_inviter` [missing-attribute]
+    --> tests/unit_tests/services/test_account_service.py:1919:27
+ERROR Object of class `TestRegisterService` has no attribute `_create_tenant_with_inviter` [missing-attribute]
+    --> tests/unit_tests/services/test_account_service.py:1951:27
 ERROR Argument `_FakeWriteSession` is not assignable to parameter `session` with type `Session` in function `services.agent_app_feature_service.AgentAppFeatureConfigService.update_features` [bad-argument-type]
    --> tests/unit_tests/services/test_agent_app_feature_service.py:102:21
 ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
@@ -7653,25 +7669,233 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.SegmentService.delete_child_chunk` [bad-argument-type]
    --> tests/unit_tests/services/test_dataset_service_segment.py:930:60
 ERROR Argument `str` is not assignable to parameter `type` with type `Literal['basic', 'bearer', 'custom'] | None` in function `services.entities.external_knowledge_entities.external_knowledge_entities.AuthorizationConfig.__init__` [bad-argument-type]
-   --> tests/unit_tests/services/test_external_dataset_service.py:118:60
+   --> tests/unit_tests/services/test_external_dataset_service.py:121:60
 ERROR Argument `str` is not assignable to parameter `type` with type `Literal['api-key', 'no-auth']` in function `services.entities.external_knowledge_entities.external_knowledge_entities.Authorization.__init__` [bad-argument-type]
-   --> tests/unit_tests/services/test_external_dataset_service.py:119:35
+   --> tests/unit_tests/services/test_external_dataset_service.py:122:35
 ERROR Argument `None` is not assignable to parameter `api_settings` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.validate_api_list` [bad-argument-type]
-   --> tests/unit_tests/services/test_external_dataset_service.py:421:54
+   --> tests/unit_tests/services/test_external_dataset_service.py:518:54
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.create_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:554:97
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.create_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:579:103
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.create_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:595:98
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.create_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:606:98
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.create_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:623:103
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.create_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:644:103
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.create_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:665:103
+ERROR Argument `Session` is not assignable to parameter `external_knowledge_api_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.get_external_knowledge_api` [bad-argument-type]
+   --> tests/unit_tests/services/test_external_dataset_service.py:940:68
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.get_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:940:92
+ERROR Argument `Session` is not assignable to parameter `external_knowledge_api_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.get_external_knowledge_api` [bad-argument-type]
+   --> tests/unit_tests/services/test_external_dataset_service.py:951:63
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.get_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:951:97
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+   --> tests/unit_tests/services/test_external_dataset_service.py:981:71
+ERROR Argument `Literal['api-123']` is not assignable to parameter `args` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+   --> tests/unit_tests/services/test_external_dataset_service.py:981:107
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [unexpected-positional-argument]
+   --> tests/unit_tests/services/test_external_dataset_service.py:981:115
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1013:13
+ERROR Argument `Literal['api-123']` is not assignable to parameter `args` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1013:52
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1013:60
 ERROR Argument `str | None` is not assignable to parameter `s` with type `bytearray | bytes | str` in function `json.loads` [bad-argument-type]
-   --> tests/unit_tests/services/test_external_dataset_service.py:934:31
-ERROR Argument `list[dict[str, list[dict[str, bool | str]]]]` is not assignable to parameter `settings` with type `dict[str, Any] | None` in function `ExternalDatasetServiceTestDataFactory.create_external_knowledge_api_mock` [bad-argument-type]
-    --> tests/unit_tests/services/test_external_dataset_service.py:1152:82
-ERROR Argument `list[dict[str, list[dict[str, bool | str]]]]` is not assignable to parameter `settings` with type `dict[str, Any] | None` in function `ExternalDatasetServiceTestDataFactory.create_external_knowledge_api_mock` [bad-argument-type]
-    --> tests/unit_tests/services/test_external_dataset_service.py:1174:82
-ERROR Argument `list[dict[Unknown, Unknown]]` is not assignable to parameter `settings` with type `dict[str, Any] | None` in function `ExternalDatasetServiceTestDataFactory.create_external_knowledge_api_mock` [bad-argument-type]
-    --> tests/unit_tests/services/test_external_dataset_service.py:1203:67
-ERROR Argument `list[dict[str, list[dict[str, bool | str]]]]` is not assignable to parameter `settings` with type `dict[str, Any] | None` in function `ExternalDatasetServiceTestDataFactory.create_external_knowledge_api_mock` [bad-argument-type]
-    --> tests/unit_tests/services/test_external_dataset_service.py:1223:67
-ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/services/test_external_dataset_service.py:1515:16
-ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/services/test_external_dataset_service.py:1516:16
+    --> tests/unit_tests/services/test_external_dataset_service.py:1017:31
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1030:17
+ERROR Argument `Literal['api-123']` is not assignable to parameter `args` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1030:59
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1030:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1044:17
+ERROR Argument `Literal['api-123']` is not assignable to parameter `args` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1044:61
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1044:72
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1062:13
+ERROR Argument `Literal['api-123']` is not assignable to parameter `args` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1062:55
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.update_external_knowledge_api` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1062:66
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.delete_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1085:62
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.delete_external_knowledge_api` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1085:89
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.delete_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1096:66
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.delete_external_knowledge_api` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1096:96
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.delete_external_knowledge_api` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1107:66
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.delete_external_knowledge_api` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1107:98
+ERROR Argument `Session` is not assignable to parameter `external_knowledge_api_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.external_knowledge_api_use_check` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1133:81
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.external_knowledge_api_use_check` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1133:105
+ERROR Argument `Session` is not assignable to parameter `external_knowledge_api_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.external_knowledge_api_use_check` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1161:81
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.external_knowledge_api_use_check` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1161:105
+ERROR Argument `Session` is not assignable to parameter `external_knowledge_api_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.external_knowledge_api_use_check` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1184:81
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.external_knowledge_api_use_check` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1184:105
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.get_external_knowledge_binding_with_dataset_id` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1208:13
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.get_external_knowledge_binding_with_dataset_id` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1208:40
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.get_external_knowledge_binding_with_dataset_id` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1222:17
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.get_external_knowledge_binding_with_dataset_id` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1222:47
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1252:62
+ERROR Argument `Literal['api-123']` is not assignable to parameter `process_parameter` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1252:89
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1252:97
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1271:66
+ERROR Argument `Literal['api-123']` is not assignable to parameter `process_parameter` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1271:93
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1271:101
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1279:66
+ERROR Argument `Literal['api-123']` is not assignable to parameter `process_parameter` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1279:96
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1279:107
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1291:62
+ERROR Argument `Literal['api-123']` is not assignable to parameter `process_parameter` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1291:92
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1291:103
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1312:62
+ERROR Argument `Literal['api-123']` is not assignable to parameter `process_parameter` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1312:92
+ERROR Expected argument `session` to be passed by name in function `services.external_knowledge_service.ExternalDatasetService.document_create_args_validate` [unexpected-positional-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1312:103
+ERROR `None` is not subscriptable [unsupported-operation]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1595:16
+ERROR `None` is not subscriptable [unsupported-operation]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1596:16
+ERROR Argument `dict[str, str | dict[str, float | int]]` is not assignable to parameter `args` with type `ExternalDatasetCreatePayload` in function `services.external_knowledge_service.ExternalDatasetService.create_external_dataset` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1626:85
+ERROR Argument `dict[str, str]` is not assignable to parameter `args` with type `ExternalDatasetCreatePayload` in function `services.external_knowledge_service.ExternalDatasetService.create_external_dataset` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1659:86
+ERROR Argument `dict[str, str]` is not assignable to parameter `args` with type `ExternalDatasetCreatePayload` in function `services.external_knowledge_service.ExternalDatasetService.create_external_dataset` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1673:86
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1730:75
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1731:13
+ERROR Argument `Literal['test query for retrieval']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1731:52
+ERROR Argument `dict[str, bool | int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1731:59
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1746:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1747:17
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1747:62
+ERROR Argument `dict[@_, @_]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1747:71
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1762:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1763:17
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1763:62
+ERROR Argument `dict[@_, @_]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1763:71
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1781:75
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1782:13
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1782:58
+ERROR Argument `dict[str, int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1782:67
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1809:75
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1810:13
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1810:58
+ERROR Argument `dict[str, bool | float | int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1810:67
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1835:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1836:17
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1836:62
+ERROR Argument `dict[str, int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1836:71
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1876:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1877:17
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1877:56
+ERROR Argument `dict[str, int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1877:65
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1896:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1897:17
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1897:62
+ERROR Argument `dict[str, int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1897:71
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1913:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1914:17
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1914:62
+ERROR Argument `dict[str, int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1914:71
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1930:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1931:17
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1931:62
+ERROR Argument `dict[str, int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1931:71
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1947:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1948:17
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1948:62
+ERROR Argument `dict[str, int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1948:71
+ERROR Missing argument `session` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [missing-argument]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1960:70
+ERROR Argument `Session` is not assignable to parameter `tenant_id` with type `str` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1961:17
+ERROR Argument `Literal['query']` is not assignable to parameter `external_retrieval_parameters` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1961:62
+ERROR Argument `dict[str, int]` is not assignable to parameter `metadata_condition` with type `MetadataFilteringCondition | None` in function `services.external_knowledge_service.ExternalDatasetService.fetch_external_knowledge_retrieval` [bad-argument-type]
+    --> tests/unit_tests/services/test_external_dataset_service.py:1961:71
 ERROR Argument `Literal['invalid']` is not assignable to parameter `session_factory` with type `Engine | sessionmaker[Unknown] | None` in function `services.file_service.FileService.__init__` [bad-argument-type]
   --> tests/unit_tests/services/test_file_service.py:48:41
 ERROR Argument `list[FromClause]` is not assignable to parameter `tables` with type `Sequence[Table] | None` in function `sqlalchemy.sql.schema.MetaData.create_all` [bad-argument-type]

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 52.77% 52.84% +0.07%
Strict coverage 52.28% 52.35% +0.07%
Typed symbols 32,716 32,760 +44
Untyped symbols 29,557 29,513 -44
Modules 2986 2986 0

@asukaminato0721 asukaminato0721 marked this pull request as draft July 7, 2026 06:56
auto-merge was automatically disabled July 7, 2026 06:56

Pull request was converted to draft

@asukaminato0721 asukaminato0721 force-pushed the mock-to-sqlite3-1 branch 2 times, most recently from 393750c to 9e40899 Compare July 10, 2026 04:27
.
.

.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant