feat: trace the remaining request parameters pi puts on the wire - #30
Merged
Merged
Conversation
milanagm
added a commit
that referenced
this pull request
Sep 15, 2026
* feat: trace the remaining request parameters pi puts on the wire * test: assert sampling parameters against the wire, not the model config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #29, base is
feat/model-parameters, so this diff is only the additions.Change
This PR adds the rest of what pi actually puts on the wire, each read off the request payload:
thinking_budget_tokensprompt_cache_retention"24h"(OpenAI) /"1h"(Anthropic) — cost-relevantservice_tiertool_choicetypeof the object formtemperature,top_p,top_k,min_p, …Plus
context_windowin the generation metadata.Tests
pnpm typecheckclean.pnpm test87/87, up from 75 on #29.End-to-end through the real pi CLI:
prompt_cache_retention: "24h"withcompat.supportsLongCacheRetentioninmodels.jsonandPI_CACHE_RETENTION=longcontext_windowon every generation