Preserve the primary hook failure during shutdown#35
Open
wallacelim wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
fail_on_error=true, a rollout-conversion failure is thrown from the hook'stryblock. If telemetry shutdown then also fails infinally, the shutdown error replaces the original conversion error, hiding the root cause.Change
Capture both failures while still always attempting shutdown, then rethrow the conversion failure first. A shutdown-only failure continues to propagate, and the default fail-open behavior is unchanged.
This is intentionally separate from usage accounting (#28), hook path portability (#33), and service-tier pricing (#34).
Validation
corepack pnpm@9.5.0 test— 36 passingcorepack pnpm@9.5.0 run lint— Prettier, TypeScript, and generated-bundle checks pass