Repository navigation
Temporary screenshot upload for sidebar drag fix - #1
Closed
laneysmith wants to merge 1 commit into
Closed
laneysmith wants to merge 1 commit into
laneysmith wants to merge 1 commit into
Conversation
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Laney Pouzet <laneys@squareup.com>
laneysmith
added a commit
to block/buzz-app
that referenced
this pull request
Nov 3, 2026
## Problem With the GitHub plugin enabled, ordinary clicks open links in Buzz’s side panel. ⌘-click should let you open a link directly in your browser while keeping the plugin’s PR status indicators and previews, but currently it does nothing. ## Solution Send desktop ⌘-clicks through the existing browser-opening command. This lets you keep the GitHub plugin enabled and choose per click: regular click for its side panel, or ⌘-click to bypass the panel and open the link in your browser. Show the existing error toast if opening fails. ## Test steps - `bin/pnpm exec vitest run src/features/conversation/MessageLink.test.tsx`: 23 tests passed. The new browser-opening and error cases failed before the fix. - Mandatory pre-push checks passed: TypeScript, related Vitest tests, and design-system checks. `BUZZ_TEST_WORKERS=2 bin/pnpm exec vitest run` passed: 884 files and 15,683 tests (7 files / 21 tests skipped). - Native macOS check passed using [laneysmith#1](laneysmith#1): ordinary click opened the side panel; ⌘-click opened the exact URL in Chrome. Human acceptance is pending. ## Videos and Screenshots macOS: regular click opens the GitHub side panel; ⌘-click opens the same public PR in the default browser. The input HUD is visible; the browser account notice is covered. https://github.com/user-attachments/assets/e3f786de-62ca-4b89-a2dd-c30d07cd5529 --------- Signed-off-by: Laney Pouzet <laneys@squareup.com> Co-authored-by: Jello Canelé <417c271f0f8eb7d0c3eb9e706a364c84a9e938d7ac18621dc30185109fcaac49@buzz.block.builderlab.xyz>
arividar
pushed a commit
to minniai/minni-buzz-app
that referenced
this pull request
Nov 4, 2026
…k#2288) ## Problem With the GitHub plugin enabled, ordinary clicks open links in Buzz’s side panel. ⌘-click should let you open a link directly in your browser while keeping the plugin’s PR status indicators and previews, but currently it does nothing. ## Solution Send desktop ⌘-clicks through the existing browser-opening command. This lets you keep the GitHub plugin enabled and choose per click: regular click for its side panel, or ⌘-click to bypass the panel and open the link in your browser. Show the existing error toast if opening fails. ## Test steps - `bin/pnpm exec vitest run src/features/conversation/MessageLink.test.tsx`: 23 tests passed. The new browser-opening and error cases failed before the fix. - Mandatory pre-push checks passed: TypeScript, related Vitest tests, and design-system checks. `BUZZ_TEST_WORKERS=2 bin/pnpm exec vitest run` passed: 884 files and 15,683 tests (7 files / 21 tests skipped). - Native macOS check passed using [laneysmith#1](laneysmith#1): ordinary click opened the side panel; ⌘-click opened the exact URL in Chrome. Human acceptance is pending. ## Videos and Screenshots macOS: regular click opens the GitHub side panel; ⌘-click opens the same public PR in the default browser. The input HUD is visible; the browser account notice is covered. https://github.com/user-attachments/assets/e3f786de-62ca-4b89-a2dd-c30d07cd5529 --------- Signed-off-by: Laney Pouzet <laneys@squareup.com> Co-authored-by: Jello Canelé <417c271f0f8eb7d0c3eb9e706a364c84a9e938d7ac18621dc30185109fcaac49@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots for block/buzz-app#1997.