Skip to content

Conversation

@florianPat
Copy link
Contributor

@florianPat florianPat commented Jan 2, 2026

Lando setup was not run, even if SETUP=1 because of the compare_version call.
No, it runs for any version which is greater than 3.23.999, as the 3.23 branch did not need it. Also, only for this condition the "-slim" binary is downloaded if FAT is not set, because that does not exist as of 3.24.

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally


Note

Adjusts POSIX installer logic for Lando 3 around the 3.24 cutoff and adds CI coverage.

  • In setup-lando.sh, fixes version comparison and conditions so -slim is appended only for <3.24 and autosetup is not disabled for >=3.24
  • Adds .github/workflows/pr-posix-script-slim-url-logic-tests.yml to verify: no -slim suffix for 3.24+ (3.24.0, 3-stable, 3-edge) and -slim suffix for pre-3.24 (v3.23.0, v3.21.0-beta.10)

Written by Cursor Bugbot for commit 44dd8ae. This will update automatically on new commits. Configure here.

…f it is set and we are >= 3.24 and the -slim download still works
@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for setup-lando ready!

Name Link
🔨 Latest commit 44dd8ae
🔍 Latest deploy log https://app.netlify.com/projects/setup-lando/deploys/6961cfbc3c67a90007453baf
😎 Deploy Preview https://deploy-preview-108--setup-lando.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 61 (🟢 up 31 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for get-lando canceled.

Name Link
🔨 Latest commit 44dd8ae
🔍 Latest deploy log https://app.netlify.com/projects/get-lando/deploys/6961cfbca6dca40008b3fba4

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants