fix(index): release IVF late-search barrier for skipped deltas - #8350
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
fix(index): release IVF late-search barrier for skipped deltas#8350lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
Every delta now joins the existing completion barrier before any no-work exit, restoring the invariant that all initial searches finish before siblings begin late probing. The focused fix preserves current query behavior and adds regression coverage for the mixed-branch case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The shared delta countdown was decremented only after the no-more-probes early return. When heterogeneous IVF segments took different paths, the skipped delta never released the barrier and its sibling waited forever.
Validation
Fixes #8349