fix(summary): identify CSV financial year - #214
Conversation
Put financial_year first so it pairs naturally with period for human readers. Repeat the plan-validated single value on every data row: row-level CSV extraction and recombination retain scope without introducing a non-tabular preamble. Do not change the context header: context rows are transient identity-bearing workbook input, not an emitted artifact, so adding scope there would widen an internal sensitive contract without helping a CSV consumer. A per-row column is preferable to file metadata because the CSV is a fixed tidy table and its rows are consumed independently. The plan must contain exactly one financial year before rows are built. Existing toCsv serialization continues to apply the same CSV/formula screening as adjacent fields.
|
Recording the audit gap for the merged head, per This PR merged with no automated review at all — not merely none at the merged head. Querying reviews by Verified on merged master What I checked independently rather than accepting from the implementation report, since that is the only review this change received:
Not covered. No live authenticated run produced a real |
Summary
Add
financial_yearas the first column of the unreleased full-year summary CSV and repeat the selected scope in every row.Root Cause / Decision Record
financial_yearcolumn keeps the human-readable year/period pair together and preserves scope if a row is extracted or recombined.Scope
Pack Workflow Preflight
pnpm workflow:preflightwas run before editing/push, or the skip reason is documented.Sanchika Adoption Gate
@sanchika/*packages or copied Sanchika guidance.../sanchika,sanchika/packages/*/src, or parent source paths.Privacy And Data-Flow Impact
Sensitive Surface Review
Chrome Web Store Impact
docs/PUBLICATION_READINESS.mdis checked.Verification
pnpm install --frozen-lockfilepnpm audit --audit-level highpnpm exec wxt preparepnpm exec prettier --check .pnpm exec eslint . --max-warnings 0pnpm exec tsc --noEmitpnpm exec vitest runpnpm exec wxt buildnode scripts/verify-extension-package.mjs .output/chrome-mv3pnpm exec wxt zip(release-only)node scripts/verify-extension-zip.mjs(release-only)node scripts/write-release-provenance.mjs(release-only)node scripts/verify-github-release-assets.mjs --tag <tag> --zip <zip> --checksum <sha256> --provenance <json>(release assets absent)node scripts/publish-chrome-web-store.mjs --zip .output/<zip> --provenance .output/pack-release-provenance.v1.json --publisher-id <id> --dry-run true(release-only)git diff --checkpnpm review:gate -- --strict-head-review --required-review-author chatgpt-codex-connector --wait-head-review-ms 180000 --allow-missing-head-reviewbefore merge/readiness claim; this draft is not merge-ready.Artifact Evidence
682c68fPR Review Follow-Up
Linked follow-up: FILED_RETURNS_SUMMARY_CONTEXT_HEADERS is exported and read by nothing #215 documents the unreferenced transient context-header export; it is out of scope for this PR.
6534830,a136c27, emitted CSV and ZIP assertionsScreenshots
Not applicable: generated CSV schema change, covered by synthetic text assertions.
DCO
Signed-off-by:trailers.