Skip to content

Select: auto-scroll selected option into view on open (align activeIndex to selected) #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codegen-sh wants to merge 1 commit into from
Closed

Select: auto-scroll selected option into view on open (align activeIndex to selected) #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/components/src/ui/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export function Select({
if (popoverState.isOpen && selectedItemRef.current) {
// Use setTimeout to ensure the DOM is fully rendered
setTimeout(() => {
selectedItemRef.current?.scrollIntoView({ block: 'nearest' });
selectedItemRef.current?.scrollIntoView({ block: 'center' });
}, 0);
}
}, [popoverState.isOpen]);
Expand All @@ -78,7 +78,8 @@ export function Select({
// Reset activeIndex when filtered items change or dropdown opens
React.useEffect(() => {
if (popoverState.isOpen) {
setActiveIndex(0);
const selectedIndex = filtered.findIndex((o) => o.value === value);
setActiveIndex(selectedIndex >= 0 ? selectedIndex : 0);
// Add a small delay to ensure the component is fully initialized
const timer = setTimeout(() => {
setIsInitialized(true);
Expand All @@ -87,14 +88,14 @@ export function Select({
} else {
setIsInitialized(false);
}
}, [filtered, popoverState.isOpen]);
}, [filtered, popoverState.isOpen, value]);

// Scroll active item into view when activeIndex changes
React.useEffect(() => {
if (popoverState.isOpen && listContainerRef.current && filtered.length > 0) {
const activeElement = listContainerRef.current.querySelector(`[data-index="${activeIndex}"]`) as HTMLElement;
if (activeElement) {
activeElement.scrollIntoView({ block: 'nearest' });
activeElement.scrollIntoView({ block: 'center' });
}
}
}, [activeIndex, popoverState.isOpen, filtered.length]);
Expand Down