Fix PasswordField export issue and bump version to 0.19.2 - #115
Fix PasswordField export issue and bump version to 0.19.2#115codegen-sh[bot] wants to merge 1 commit into
Conversation
- Built the components package to generate missing dist files - PasswordField was already properly exported in source but dist was missing - Bumped version from 0.19.1 to 0.19.2 as requested - The export '@lambdacurry/forms/remix-hook-form' now properly provides PasswordField
|
|
WalkthroughThe change consists solely of updating the version number in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
|
@codegen-sh can we double check that it's exporting from
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/components/package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
{package.json,packages/**/package.json,apps/**/package.json}
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo-organization.mdc)
Use consistent versioning across packages
Files:
packages/components/package.json
{packages/**/package.json,apps/**/package.json}
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo-organization.mdc)
Define peerDependencies, dependencies, and devDependencies appropriately in package.json
Files:
packages/components/package.json
| { | ||
| "name": "@lambdacurry/forms", | ||
| "version": "0.19.1", | ||
| "version": "0.19.2", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Version bump acknowledged – verify downstream alignment
The bump to 0.19.2 itself is fine, but make sure every other package.json in the monorepo (apps and packages) that declares a dependency on @lambdacurry/forms is updated to the same version or to a range (^0.19.2) that includes it; otherwise yarn workspaces / external consumers may pull mismatched builds.
🏁 Script executed:
#!/bin/bash
# Locate every package.json that depends on @lambdacurry/forms and show the specified version.
fd package.json -t f -E node_modules | xargs -I{} jq -r \
'select(.dependencies."@lambdacurry/forms" or .peerDependencies."@lambdacurry/forms")
| (.name // "unknown-package") + ": " +
((.dependencies."@lambdacurry/forms" // .peerDependencies."@lambdacurry/forms"))' {} || trueLength of output: 309
Align @lambdacurry/forms version in downstream packages
Only one other package.json declares a dependency on @lambdacurry/forms, and it’s using the wildcard ("*") range. To avoid unpredictable pulls and ensure consistency with your new 0.19.2 release, please pin it to ^0.19.2:
• packages/forms-docs/package.json
- "@lambdacurry/forms": "*",
+ "@lambdacurry/forms": "^0.19.2",This will keep your workspaces and external consumers all on the same patch line.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/components/package.json at line 3, update the version of the
@lambdacurry/forms dependency from "*" to "^0.19.2" to align with the new
release version and ensure consistent dependency resolution across downstream
packages.
|
✅ Double-checked and confirmed! The 🔍 Export verification:
📦 The import path 🎯 Root cause was confirmed: The 💻 View my work • 🛑 Stop |
1 participant
Problem
The import
@lambdacurry/forms/remix-hook-formwas failing with the error:Root Cause
The issue was that the
distfolder was missing from the components package. While thePasswordFieldwas properly exported in the source code (packages/components/src/remix-hook-form/index.ts), the built distribution files were not present.Solution
yarn buildto generate the missingdistfilesPasswordFieldis properly exported in both:dist/remix-hook-form/index.js(line 29:D as PasswordField)dist/remix-hook-form/index.d.ts(line 7:export * from './password-field')0.19.1to0.19.2as requestedChanges
0.19.2PasswordFieldexport is now available from@lambdacurry/forms/remix-hook-formTesting
The build completed successfully and the
PasswordFieldexport is now properly available in the built distribution files.Requested by Jake Ruesink
💻 View my work • About Codegen
⛔ Remove Codegen from PR • 🚫 Ban action checks
Summary by CodeRabbit