fix(menu): wire Show/Hide Floating Bar tray menu item to WindowManager - #491
Open
lacymorrow wants to merge 1 commit into
Conversation
The tray and app menu items emitted toggle-floating-bar-requested but no handler existed, so clicking Show/Hide Floating Bar did nothing. Add a backend listener in setup_event_listeners that toggles the floating-bar window visibility via WindowManager show/hide. Closes LAC-3044 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHOW_HIDE_FLOATING_BAR(tray) andTOGGLE_FLOATING_BAR(app menu) emittedtoggle-floating-bar-requestedbut no listener existed — clicking the menu item did nothingsetup_menu_event_listenersinevents/handlers.rs, called fromsetup_event_listenerson startupWindowManager::is_window_visiblethenhide_window/window.show()to toggle the floating-bar windowTest plan
TOGGLE_FLOATING_BARCloses LAC-3044
🤖 Generated with Claude Code