Repository navigation
Conversation
Upgrade every Go dependency to its latest release, including the DuckDB driver github.com/duckdb/duckdb-go/v2 from v2.10506.0 to v2.20000.0 and the bindings from v0.10506.0 to v0.20000.0, whose native modules moved to go.duckdb.org/libduckdb/*. The pinned native engine is unchanged: both the old and new bindings target DuckDB v2.0.0 (source d54cbbe3df), so SELECT version() and the reviewed built-in-function snapshot are identical and the engine's checksums in scripts/with-duckdb.sh stay as they are. The new bindings register static extensions through a loader symbol, duckdb_register_static_extensions, that their init calls before any database opens. The prebuilt platform modules define it; Pitot links its own minimal static engine (core functions, JSON, Parquet, ICU) through scripts/with-duckdb.sh instead, so internal/duckdb now exports that loader with exactly those four extensions and no longer registers them a second time from its own init.
The Go dependency graph changed with the module upgrade, so the committed THIRD_PARTY_NOTICES no longer matches it and notices-check fails. Regenerate it (284 components).
vishr
enabled auto-merge
November 16, 2026 17:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades every Go dependency to its latest release with
go get -u ./..., including the DuckDB drivergithub.com/duckdb/duckdb-go/v2(v2.10506.0 → v2.20000.0) and its bindings (v0.10506.0 → v0.20000.0), whose native modules moved togo.duckdb.org/libduckdb/*. This is the deferred remainder of the dependency sweep (closed #492/#418 bundled the same DuckDB driver bump without the native-integration change this PR makes).The native engine is unchanged
Both the old and new bindings target DuckDB v2.0.0 (source
d54cbbe3df, per the bindings'duckdb-release.json), which is exactly whatscripts/with-duckdb.shalready pins. So:SELECT version()still returnsv2.0.0(the pinned-engine and checkpoint tests assert this).TestBuiltinFunctionsMatchTheReviewedSnapshotpasses without regeneration).scripts/with-duckdb.share untouched.This is a Go binding-layer upgrade, not an engine upgrade, so it needs no new built-in review and no re-benchmark.
Static-extension loader
Bindings v0.20000.0 changed how static extensions load: their
initnow calls a loader symbolduckdb_register_static_extensionsbefore any database opens. The prebuiltgo.duckdb.org/libduckdb/<platform>modules define it, but Pitot deliberately links its own minimal static engine (core functions, JSON, Parquet, ICU) throughscripts/with-duckdb.shinstead of those modules, so the symbol was undefined and the link failed:internal/duckdb/native.goalready registered those four extensions from its owninit. It now exportsduckdb_register_static_extensionswith exactly those four extensions — the symbol the bindings call — and drops the duplicate self-registration frominit(keeping thev2.0.0version guard). Registration still happens once, now driven by the bindings'init.Other upgrades
cel-go, echo, goose, grpc, modernc.org/sqlite, go-mail, prometheus/procfs, the
golang.org/x/*modules, and the usual indirect set, all to latest.Verification
just vet: clean.just test ./internal/engine/...version/snapshot/blocklist tests (TestCheckpointScanLock*,TestBuiltinFunctionsMatchTheReviewedSnapshot,TestScalarMacrosThatRunQueriesAreBlocked): pass —SELECT version()==v2.0.0, snapshot unchanged.just test ./internal/telemetry/store/...and./internal/engine/...: pass.gofmt,just go-deadcode,just test-names-check: clean.