Repository navigation
chore!: remove previous-name compatibility - #470
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove previous-name documentation redirects, compatibility tests and upgrade promises. Refresh both architecture-specific Parquet digests for the intentional footer-byte change. Verify zombie ownership before waiting for teardown, and let schema cache hits bypass the completion admission mutex while preserving one fetch per key.
The two published migration edits are a one-time owner-approved exception to the immutable-migration rule, comment-only. Their SQL is unchanged; only the two test-ledger checksums are updated. The AGENTS.md rule is unchanged.
Evidence
just check-static,just test,just ui-test, and all seven Go race shards). These are the completejust checkcomponents plus race checks.just check-staticandjust testpass locally. The direct full UI suite (cd ui/host && bun run test) passes all 1,790 tests across 122 files.just checkreaches the UI suite but the sandbox denies process inspection for nested lifecycle tests; the same suite passes when invoked directly. Linux CI runs the three gate components independently.just test-race ./internal/pitotql -run TestComplete -count=200: passed.just test-race ./internal/telemetry ./internal/store ./internal/db ./cmd/pitot: passed.git grep -n -i -I 'fanout\|fanql': no matches.git ls-files | grep -i 'fanout\|fanql': no matches.git diff --check: passed. Compared both migration files with the base after removing comment lines: SQL unchanged.Before: startup refused unrelated service-link variables, teardown waited for unowned zombies, and schema cache hits held the admission mutex. After: the refusal is removed, the zombie regression passes, and 200 race-enabled repetitions verify cache hits and fetch coalescing.
Merge Danger
Door: one-way
FANOUT_variables are ignored,fanout.sqliteis no longer migrated, and old batches withfanout.spill.keys fail verification. There are no aliases, fallbacks or compatibility migrations.Blast Radius: storage
Deployments must supply current settings and the current control database filename and telemetry footer namespace before upgrading.