Skip to content

chore!: remove previous-name compatibility - #470

Merged
vishr merged 3 commits into
mainfrom
chore/drop-previous-name-compat
Nov 12, 2026
Merged

vishr merged 3 commits into
mainfrom
chore/drop-previous-name-compat

Conversation

@vishr

@vishr vishr commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Summary

- startup: refuse previous environment names and migrate the control filename
+ startup: read current configuration and open control/pitot.sqlite
- telemetry: preserve the previous spill footer namespace
+ telemetry: use pitot.spill. exclusively

Remove previous-name documentation redirects, compatibility tests and upgrade promises. Refresh both architecture-specific Parquet digests for the intentional footer-byte change. Verify zombie ownership before waiting for teardown, and let schema cache hits bypass the completion admission mutex while preserving one fetch per key.

The two published migration edits are a one-time owner-approved exception to the immutable-migration rule, comment-only. Their SQL is unchanged; only the two test-ledger checksums are updated. The AGENTS.md rule is unchanged.

Evidence

  • Linux CI Gate: passed (just check-static, just test, just ui-test, and all seven Go race shards). These are the complete just check components plus race checks.
  • Gate recipes: just check-static and just test pass locally. The direct full UI suite (cd ui/host && bun run test) passes all 1,790 tests across 122 files.
  • Local combined just check reaches the UI suite but the sandbox denies process inspection for nested lifecycle tests; the same suite passes when invoked directly. Linux CI runs the three gate components independently.
  • just test-race ./internal/pitotql -run TestComplete -count=200: passed.
  • just test-race ./internal/telemetry ./internal/store ./internal/db ./cmd/pitot: passed.
  • Native Linux AMD64 telemetry race suite: passed, verifying the refreshed AMD64 digest.
  • Lifecycle regression suite: 12 tests passed, including an unowned zombie at a recorded PID.
  • git grep -n -i -I 'fanout\|fanql': no matches.
  • git ls-files | grep -i 'fanout\|fanql': no matches.
  • git diff --check: passed. Compared both migration files with the base after removing comment lines: SQL unchanged.

Before: startup refused unrelated service-link variables, teardown waited for unowned zombies, and schema cache hits held the admission mutex. After: the refusal is removed, the zombie regression passes, and 200 race-enabled repetitions verify cache hits and fetch coalescing.

Merge Danger

Door: one-way

FANOUT_ variables are ignored, fanout.sqlite is no longer migrated, and old batches with fanout.spill. keys fail verification. There are no aliases, fallbacks or compatibility migrations.

Blast Radius: storage

Deployments must supply current settings and the current control database filename and telemetry footer namespace before upgrading.

@vishr
vishr marked this pull request as ready for review November 12, 2026 18:18
@vishr
vishr added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit cbb111b Nov 12, 2026
33 checks passed
@vishr
vishr deleted the chore/drop-previous-name-compat branch November 12, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant