Skip to content

fix(alert): keep a newer email failure visible on the rule - #462

Merged
vishr merged 1 commit into
mainfrom
fix/alert-status-and-create-message
Nov 9, 2026
Merged

vishr merged 1 commit into
mainfrom
fix/alert-status-and-create-message

Conversation

@vishr

@vishr vishr commented Nov 9, 2026

Copy link
Copy Markdown
Member

Follow-ups from review of #455 and #459.

  • Dropping every recipient of an old notification cleared the rule's email status, even when a newer notification had set it, which could hide a failure. It now clears only a status that still reads retrying. A new test fails without the guard.
  • The 403 for POST /api/users said the identity provider creates accounts, which is false when role mapping is on and nothing provisions them. The message now holds in every mode.

Dropping every recipient of an old notification cleared the rule's email
status even when a newer notification had set it. Clear it only while it
still reads retrying.

Also make the refusal for creating a user accurate in every identity
provider mode, including the one where nothing provisions accounts.
@vishr
vishr enabled auto-merge November 9, 2026 00:47
@vishr
vishr added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 2bd262c Nov 9, 2026
31 checks passed
@vishr
vishr deleted the fix/alert-status-and-create-message branch November 9, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant