Skip to content

fix(ui): finish console redesign follow-ups - #436

Merged
vishr merged 8 commits into
mainfrom
fix/ui-followups
Nov 8, 2026
Merged

vishr merged 8 commits into
mainfrom
fix/ui-followups

Conversation

@vishr

@vishr vishr commented Nov 8, 2026

Copy link
Copy Markdown
Member

Follow-ups from the review of the console redesign.

  • The collapsed rail's Chats and Dashboards menus say when they are loading
    or could not load, with a retry, instead of claiming there are none.
  • An empty panel pinned to its own time range no longer offers to widen the
    dashboard range, and says how to change its range instead.
  • Embedded views without a host theme follow system theme changes live.
  • A page's time picker reads the phone breakpoint synchronously, so it never
    flashes into the hidden header slot.
  • Scatter axis names drop the unit when the ticks already print it, and
    percent axes print every tick with the decimals the step needs (0.0%, 0.5%,
    1.0%).

Verification: just check, 1,761 unit tests and the design check (396 story
tests) pass. New tests cover the empty-state actions, picker placement, the
rail's failure states and percent ticks. macOS visual baselines are refreshed;
the Linux baselines are taken from this PR's CI run.

vishr added 7 commits November 7, 2026 20:29
- The collapsed rail's Chats and Dashboards menus say when they are loading
  or could not load, with a retry, instead of claiming there are none.
- An empty panel pinned to its own time range no longer offers to widen the
  dashboard range, and says how to change its range instead.
- Embedded views without a host theme follow system theme changes live.
- A page's time picker reads the phone breakpoint synchronously, so it never
  flashes into the hidden header slot.
- Scatter axis names drop the unit when the ticks already print it, and
  percent axes print every tick with the decimals the step needs (0.0%,
  0.5%, 1.0%).
- Tests cover the empty-state actions, picker placement, the rail's failure
  states and percent ticks. macOS visual baselines are refreshed.
# Conflicts:
#	internal/mcp/apps/panels.html
#	internal/ui/dist/assets/alerts-DfQGbENX.js
#	internal/ui/dist/assets/dashboards._dashboardId-C2t6etPx.js
#	internal/ui/dist/assets/dashboards._dashboardId-CSD2-dX6.js
#	internal/ui/dist/assets/dashboards._dashboardId-D7xQjszq.js
#	internal/ui/dist/assets/dashboards.index-BygQqNHG.js
#	internal/ui/dist/assets/dashboards.index-DKMqYoMu.js
#	internal/ui/dist/assets/dashboards.index-D_5xxkci.js
#	internal/ui/dist/assets/explore-D5UYmKD_.js
#	internal/ui/dist/assets/explore-DeZU_Tk4.js
#	internal/ui/dist/assets/explore-esQgD_Fc.js
#	internal/ui/dist/assets/index-B1wgRniL.js
#	internal/ui/dist/assets/index-Bs8vtjQI.js
#	internal/ui/dist/assets/index-DsRJ5Yuq.js
#	internal/ui/dist/assets/logs-NxZ1frmJ.js
#	internal/ui/dist/assets/logs-XA6ezHF3.js
#	internal/ui/dist/assets/logs-gUTf9CYT.js
#	internal/ui/dist/assets/mcp-app-frame-CKZ9cJwD.js
#	internal/ui/dist/assets/new-dashboard-DCNCJ5ui.js
#	internal/ui/dist/assets/new-dashboard-DVgRdDSE.js
#	internal/ui/dist/assets/new-dashboard-nj324GRp.js
#	internal/ui/dist/assets/page-9gMSkhtY.js
#	internal/ui/dist/assets/page-BlTQCd_N.js
#	internal/ui/dist/assets/page-BulFZhyB.js
#	internal/ui/dist/assets/page-_NjQVv5s.js
#	internal/ui/dist/assets/panel-editor-BLG8r3jX.js
#	internal/ui/dist/assets/panel-editor-BMBU6_Xh.js
#	internal/ui/dist/assets/panel-editor-CZkiYIIe.js
#	internal/ui/dist/assets/save-dialog-DrmMbqKq.js
#	internal/ui/dist/assets/save-dialog-Z4QY3HOt.js
#	internal/ui/dist/assets/save-dialog-avkBtcoj.js
#	internal/ui/dist/assets/search-page-B-oVsv9v.js
#	internal/ui/dist/assets/settings-B3gVAcch.js
#	internal/ui/dist/assets/settings-BiQYz0Ll.js
#	internal/ui/dist/assets/settings-DByeWKCo.js
#	internal/ui/dist/assets/traces-DlLzFd9W.js
#	internal/ui/dist/assets/traces-Pe5mJjHf.js
#	internal/ui/dist/assets/traces-ioj09qZQ.js
#	internal/ui/dist/assets/useMutation-B7vlXOiv.js
#	internal/ui/dist/assets/useMutation-M6MxJYVI.js
#	internal/ui/dist/assets/useMutation-Ox_Lme0N.js
#	internal/ui/dist/index.html
Axis names drop their unit through an explicit option, so a unit from the
panel or a column suffix no longer reappears on the wrong axis or stays
beside ticks that print it. Percent steps finer than four decimals keep
the per-value format, and fixed-decimal ticks keep thousands separators.
The decimals check used an absolute tolerance, so a step under 1e-6
matched zero places and every tick read 0%. The tolerance is now relative
to the step.
@vishr
vishr enabled auto-merge (squash) November 8, 2026 17:03
@vishr
vishr merged commit c17ad6a into main Nov 8, 2026
19 checks passed
@vishr
vishr deleted the fix/ui-followups branch November 8, 2026 17:53
vishr added a commit that referenced this pull request Nov 8, 2026
The ruleset requires a branch to be up to date with main, and main moves
several times an hour, so a pull request often fell behind during its
own CI run and needed another (#436 needed three today). A merge queue
instead tests each pull request merged onto main and the queue ahead of
it.

- CI and Leaks also run on `merge_group` events, and Container scan
scans the queued tree.
- Only pull request events can run the CLA check, so in the queue a
workflow that holds no permissions reports it as satisfied. A pull
request enters the queue only after its own CLA check passed.
- CONTRIBUTING describes the queue.

Nothing changes until the ruleset turns the queue on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant