Repository navigation
fix(query): run valid panels when one panel is invalid - #425
Merged
Merged
Conversation
Whole-spec validation let one stale panel block every sibling. Return panel-scoped invalid results while checking and running the remaining panels; keep saves strict and result keys tied to the full spec.
Treat per-panel invalid results as refused editor runs, preserving source guards and diagnostics without displaying a failed result. Keep single-panel MCP failures and save-check problems visible.
Resolve variables and healthy-panel exemplars despite invalid siblings. Ignore invalid panels for empty-result guidance, retain diagnostics across check rounds, and keep internal paths out of card errors.
Retain invalid save-check warnings and problems while reporting that validation completed. Accept that receipt in the UI with typed problems and rebuild the embedded assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A saved dashboard with one panel using a field batch format 5 removed
(
http_route; nowattributes['http.route']) failed every panel:POST /api/queries/run validated the whole spec and answered the request
with its problems.
Runs now isolate panel-scoped problems. Each such panel returns status
invalidwith its problems, and the other panels run. Problems outsidea panel (variables, time, the dashboard) still fail the request, and
saving stays strict.
query_telemetrystill returns an invalid panel as a tool error;preview_panelsand save receipts list its problems.