Skip to content

fix(query): run valid panels when one panel is invalid - #425

Merged
vishr merged 4 commits into
mainfrom
fix/run-isolates-invalid-panels
Nov 6, 2026
Merged

vishr merged 4 commits into
mainfrom
fix/run-isolates-invalid-panels

Conversation

@vishr

@vishr vishr commented Nov 6, 2026

Copy link
Copy Markdown
Member

A saved dashboard with one panel using a field batch format 5 removed
(http_route; now attributes['http.route']) failed every panel:
POST /api/queries/run validated the whole spec and answered the request
with its problems.

Runs now isolate panel-scoped problems. Each such panel returns status
invalid with its problems, and the other panels run. Problems outside
a panel (variables, time, the dashboard) still fail the request, and
saving stays strict.

  • Panels show an invalid result as their own error.
  • Explore keeps marking the editor for an invalid SQL or FanQL query.
  • MCP query_telemetry still returns an invalid panel as a tool error;
    preview_panels and save receipts list its problems.

vishr added 4 commits November 6, 2026 08:38
Whole-spec validation let one stale panel block every sibling. Return panel-scoped invalid results while checking and running the remaining panels; keep saves strict and result keys tied to the full spec.
Treat per-panel invalid results as refused editor runs, preserving
source guards and diagnostics without displaying a failed result.
Keep single-panel MCP failures and save-check problems visible.
Resolve variables and healthy-panel exemplars despite invalid siblings.
Ignore invalid panels for empty-result guidance, retain diagnostics
across check rounds, and keep internal paths out of card errors.
Retain invalid save-check warnings and problems while reporting that
validation completed. Accept that receipt in the UI with typed problems
and rebuild the embedded assets.
@vishr
vishr merged commit 914f367 into main Nov 6, 2026
18 checks passed
@vishr
vishr deleted the fix/run-isolates-invalid-panels branch November 6, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant