Skip to content

fix(ui): stop counting panels in chat card summaries - #386

Merged
vishr merged 1 commit into
mainfrom
fix/chat-card-summary
Oct 26, 2026
Merged

vishr merged 1 commit into
mainfrom
fix/chat-card-summary

Conversation

@vishr

@vishr vishr commented Oct 26, 2026

Copy link
Copy Markdown
Member

What changed

A chat card's collapsed summary read like "Performance · time series, table · 4 panels · 1 error". The chart kinds already say what the card shows, so the panel count added nothing. Multi-panel cards now list only what went wrong ("Performance · time series, table · 1 error"), and nothing when every panel returned data. A single-panel card keeps its row count, since that says whether the query found anything.

The committed UI bundle is rebuilt with just ui.

Verification

  • just check: all checks passed
  • just test-race: passed
  • ui/host/src/chat.test.tsx: the multi-panel summary test now asserts no panel count; it failed before the change and passes after
  • No credentials, private telemetry, host details, or enterprise-only source are included

A chat card's summary named its view, the kinds of chart it shows, and then
how many panels it held. The chart kinds already say what the card shows, so
the count added nothing. Multi-panel cards now add only what went wrong, such
as "1 error" or "1 empty"; a single-panel card keeps its row count, which
says whether the query found anything.
@vishr
vishr merged commit f337bcf into main Oct 26, 2026
17 checks passed
@vishr
vishr deleted the fix/chat-card-summary branch October 26, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant