Repository navigation
fix(ui): stop counting panels in chat card summaries - #386
Merged
Merged
Conversation
A chat card's summary named its view, the kinds of chart it shows, and then how many panels it held. The chart kinds already say what the card shows, so the count added nothing. Multi-panel cards now add only what went wrong, such as "1 error" or "1 empty"; a single-panel card keeps its row count, which says whether the query found anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A chat card's collapsed summary read like "Performance · time series, table · 4 panels · 1 error". The chart kinds already say what the card shows, so the panel count added nothing. Multi-panel cards now list only what went wrong ("Performance · time series, table · 1 error"), and nothing when every panel returned data. A single-panel card keeps its row count, since that says whether the query found anything.
The committed UI bundle is rebuilt with
just ui.Verification
just check: all checks passedjust test-race: passedui/host/src/chat.test.tsx: the multi-panel summary test now asserts no panel count; it failed before the change and passes after