Repository navigation
test(ui): one Playwright layout with app, mcp and visual surfaces - #358
Merged
Merged
Conversation
The browser suite moves into e2e/{fixtures,data,host,support,specs/{app,
mcp,visual},__screenshots__} with one project per surface. Specs import
test and expect only from fixtures/test, enforced by the UI boundary check.
- app: the existing specs, unchanged in behavior. The seeded Fanout server
now starts from a setup project, so mcp and visual runs do not boot it.
- mcp: the built panels MCP App runs in a mock host on the official
ext-apps AppBridge, fed tool results recorded from the synthetic e2e
seed: overview, topology, performance, trace, logs, a custom panel,
no-data, error, cancelled, loading and no-host fallback, in both
themes, with axe and keyboard checks.
- visual: screenshot assertions for the overview, performance and trace
views. Linux baselines come from the pinned Playwright image the new CI
job runs in, and that job fails if the image driver differs from the
installed @playwright/test.
The view gains a main landmark and a status role on its loader. The
host server binds an OS-assigned port. Recipes: e2e-mcp, e2e-visual,
e2e-ui, e2e-update-snapshots and e2e-linux-baselines.
Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
The smoke job now runs the mcp project, which needs Playwright's bundled Chromium; just e2e-browsers installs the locked build with its OS libraries for CI and local setup. Setup stops instances it started before replacing them, matches readiness to the spawned process, and teardown removes every instance and its temporary directories. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the browser suite into one layout and adds two surfaces: the MCP App view inside a standard host, and screenshot assertions.
app-{1100,1440}-{light,dark}. The seeded Fanout server starts from a setup project, so mcp and visual runs do not boot it. Setup owns every instance it starts, and teardown removes them all.panels.htmlMCP App, the view ChatGPT, claude.ai and other hosts load asui://fanout/panels.html, runs inside a mock host on the official@modelcontextprotocol/ext-appsAppBridge. The tool results it receives were recorded from the synthetic e2e seed, never from a real deployment. Coverage: overview, topology, performance, trace, logs, a custom panel, no-data, error, cancelled, loading and the no-host fallback, in both themes, with axe (serious/critical) and keyboard checks. The host fails on unexpected view requests.mcr.microsoft.com/playwright:v1.64.1-noble@sha256:7852dc5a…image that the new CI visual job runs in; the job fails if that image's driver differs from the installed@playwright/test. Darwin baselines are for local runs.test/expectonly frome2e/fixtures/test, enforced by the UI boundary check, with a test.e2e-mcp,e2e-visual,e2e-ui,e2e-update-snapshots,e2e-linux-baselinesande2e-browsers(the locked Chromium with OS libraries; CI smoke runs it).@playwright/test1.64.1 and@axe-core/playwright4.14.0.mainlandmark and astatusrole on its loader.docs/testing.mddocuments setup, the backend lifecycle, the mock host, recording and every recipe.Verification:
just e2e: 107 passed, 150 skipped. All 78 previous tests still pass with the same skips.just checkpasses.ui/host/e2e/data/mcp.jsoncontainsview.keyvalues, which are SHA-256 content hashes of recorded preset views, not credentials. Generic secret scanners flag them.