Repository navigation
fix: show rejected dashboard drafts as drafts, with readable receipts - #355
Merged
Merged
Conversation
Dashboard save rejections were reported with the generic tool_failed code, so chat counted a draft the agent then corrected as a failed step, and the middleware re-presented already-presented diagnoses, which could collapse a diagnosis that names an observed route into the generic read failure. Dashboard tools now answer a spec rejection with error.code invalid_spec and the presented problems, matching the HTTP API, and a stale base version with dashboard_version_conflict. Chat lists these as "N drafts rejected" with the problem messages under the panel's title, and keeps "N steps failed" for real failures; the build receipt reports whether the dashboard was saved. Receipt and history chips, details and warnings name panels by title and fields in plain words instead of spec ids and paths. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tool_failedcode. The MCP error middleware then re-presented diagnoses that were already presented, which could collapse a diagnosis naming an observed route into "Could not read the requested data."Fixed p95_by_operation.query.sortand~ latency.query.Change
error.code invalid_specfor a spec rejection, with the presentedproblemsalongside it, matching the HTTP API. A stale base version returnsdashboard_version_conflict, the HTTP API's code.dashboardToolErroris the single classifier, and restore uses it too.normalizeToolErrorsno longer re-presentsinvalid_specmessages.~ P95 latency: SQL, chart type · movedandFixed P95 latency.An earlier iteration tried to hide a rejection once a later save appeared to correct it. Each review round found another case where that inference hid a real failure, so this PR shows every rejection instead, under an accurate label.
Verification
just checkjust e2e: 78 passed