Repository navigation
fix: keep implementation details out of user-facing output - #348
Merged
Merged
Conversation
Chat, dashboards and MCP results showed storage-engine and format names, engine error classes and types, internal relation names, Go error chains, file paths and tool names. A user saw raw engine errors in result output. - One presenter in internal/panel publishes errors by cause. Operational failures (trace reads, exemplars, schema discovery, storage) show "Could not read the requested data. Try again." and log the cause. Errors about authored SQL or structured filters keep their meaning and candidate bindings, without engine branding, internal types, the telemetry schema qualifier, paths, wrapping chains or expanded server SQL. It applies to panel results, validation problems, previews, save receipts, no_data guidance and MCP tool errors; product guidance passes through unchanged. - Empty-panel diagnoses describe the filter in product language instead of quoting SQL; measure hints use plain words. - Panel captions drop the data-source label. Column headers, legends, axes, tooltips and accessibility text use readable labels such as "Avg (ms)"; data keys are unchanged. - Chat shows only the final answer: provisional text between tool calls is no longer emitted, and the activity line uses step labels. Tool failures show product step names and presented messages. - Explain and Fix post a short visible request. The panel diagnostics travel as AG-UI run context, are stored hidden with that user message, survive follow-ups and retries, and are capped at 16 KiB. - Tool results no longer carry data-source names or query IDs. The agent prompt adds rollups, aggregation tables and internal windows to the never-mention list and requires product language in panel text. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
CodeQL flagged hand-built quoting of candidate column names. The names are already restricted to identifier characters; strconv.Quote makes the escaping explicit. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlsource label, raw column names and the assistant's narration between steps.internal/panelpublishes errors by cause. Operational failures (trace reads, exemplars, schema discovery, storage) show "Could not read the requested data. Try again." and log the cause. Errors in authored SQL or structured filters keep their meaning and candidate bindings, without engine branding, engine-specific types, thetelemetry.qualifier, paths, wrapping chains or expanded server SQL. It applies to panel results, validation problems, previews, save receipts,no_dataguidance and MCP tool errors. Product guidance passes through unchanged.avg_ms→ "Avg (ms)"); data keys are unchanged.Verification
session.CallTool.go test ./...,go test -raceon touched packages, 1,418 UI tests,just ui-check,just docs-generate-check.just checkin the pre-push hook.