Repository navigation
fix(mcp): answer empty results with guidance and keep empty panels out of dashboards - #347
Merged
Merged
Conversation
…t of dashboards Chat showed empty evidence views and agent-built dashboards saved empty panels when the agent queried a signal a service does not have, such as span latency for a metrics-only messaging system or error logs that never occurred. - Fragment tools whose every result is empty return a no_data tool error instead of an empty view. The message names the services checked and the spans, logs and metrics each has in the window, or unknown_service guidance when the name is not in the data. inspect_trace still returns a trace with spans or logs. Guidance skips service lookups when a checked filter cannot be represented as an exact scope, so a namespace restriction is never lost. - create_dashboard, replace_dashboard and edit_dashboard run the spec before each write attempt and reject non-text panels that do not execute OK, with each panel's path, title and diagnosis. Panels truncated by the shared row budget count as populated. UI saves are unaffected. - Agent and server instructions no longer allow deliberately empty panels; chat no longer has an empty-view collapse path. - Landing recordings ask for a richer dashboard and fail a take with fewer than six panels, any empty panel, fewer than four chat evidence views, or an empty view. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kafka, or searched for checkout error logs that never occurred.no_datatool error instead of an empty view. The message names the services checked and their span, log and metric counts in the window, or returnsunknown_serviceguidance when the name is not in the data.inspect_tracestill returns a trace that has only spans or only logs. Guidance skips the service lookup when a checked filter cannot be represented as an exact scope, so a namespace restriction is never lost.create_dashboard,replace_dashboardandedit_dashboardrun the spec before each write attempt and reject non-text panels that do not execute OK, listing each panel's path, title and diagnosis. Panels truncated by the shared row budget count as populated. Saves from the UI are unaffected.Verification
go test -raceoninternal/agent,internal/mcp,internal/panelandinternal/dashboard;just ui-check,just docs-generate-check, UI lint.just checkin the pre-push hook.